Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent scroll upon clicking selection from suggestion list #26

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

imjohnbo
Copy link
Contributor

Summary

This pull request prevents the browser from scrolling to the bottom of a textarea when you click a selection from the suggestion list.

Here's an example based on ./examples/index.html:

Before After
before after

Thanks for taking a look! ✨

@imjohnbo imjohnbo requested a review from a team as a code owner December 15, 2021 18:37
Copy link
Contributor

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! I usually use the keyboard for selecting options, so I hadn't realized how jarring this experience can be with the mouse! Thanks for fixing ✨

@dgreif dgreif merged commit 77e88f4 into github:main Dec 16, 2021
@imjohnbo imjohnbo deleted the fix/click-selection-scroll branch December 16, 2021 18:24
Copy link

@WillaHelenA WillaHelenA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants