Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys setter #68

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add keys setter #68

merged 2 commits into from
Oct 10, 2024

Conversation

mattcosta7
Copy link
Member

@mattcosta7 mattcosta7 commented Oct 9, 2024

fixes #62

Adds a keys setter so that react 19 can properly call set on the property.

React 19 does an prop in Obj check for whether to set properties or attributes, and since keys is found due to the getter it attempts to set that property on the javascript object instead of the attribute. leading to an error since no setter is defined

this forwards the property setter to the attribute setter directly

@mattcosta7 mattcosta7 self-assigned this Oct 9, 2024
@mattcosta7 mattcosta7 marked this pull request as ready for review October 9, 2024 19:16
@mattcosta7 mattcosta7 requested a review from a team as a code owner October 9, 2024 19:16
@keithamus keithamus merged commit 4d6e63e into main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Expander is not compatible with React 19
2 participants