Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test #2981

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix failing test #2981

merged 1 commit into from
Oct 16, 2023

Conversation

koesie10
Copy link
Member

This fixes a failing test caused by a semantic merge conflict between #2965 and #2979.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 requested a review from a team as a code owner October 16, 2023 11:26
charisk
charisk approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@koesie10 koesie10 enabled auto-merge October 16, 2023 11:31
@koesie10 koesie10 merged commit 688b986 into main Oct 16, 2023
@koesie10 koesie10 deleted the koesie10/fix-failing-test branch October 16, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk