Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify custom Jest test runner #3234

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Simplify custom Jest test runner #3234

merged 1 commit into from
Jan 12, 2024

Conversation

koesie10
Copy link
Member

The custom Jest test runner was originally written to install the required extensions for the CLI integration tests. This is no longer necessary as of #3232, so we can remove all code that deals with downloading VS Code and installing extensions. The download of VS Code will now be handled by the base VSCodeTestRunner.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10
Simplify custom Jest test runner
0534cb7 
The custom Jest test runner was originally written to install the
required extensions for the CLI integration tests. This is no longer
necessary as of #3232, so
we can remove all code that deals with downloading VS Code and
installing extensions. The download of VS Code will now be handled by
the base `VSCodeTestRunner`.
@koesie10 koesie10 force-pushed the koesie10/remove-jest-runner-installed-extensions branch from 3fc1970 to 0534cb7 Compare January 12, 2024 08:49
@koesie10 koesie10 marked this pull request as ready for review January 12, 2024 09:12
@koesie10 koesie10 requested a review from a team as a code owner January 12, 2024 09:12
norascheuch
norascheuch approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@koesie10 koesie10 merged commit ea1419a into main Jan 12, 2024
25 checks passed
@koesie10 koesie10 deleted the koesie10/remove-jest-runner-installed-extensions branch January 12, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norascheuch norascheuch norascheuch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @norascheuch