Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should truncate output if it's too long #204

Closed
sunnylqm opened this issue Sep 19, 2022 · 6 comments · Fixed by #301
Closed

should truncate output if it's too long #204

sunnylqm opened this issue Sep 19, 2022 · 6 comments · Fixed by #301

Comments

@sunnylqm
Copy link
Contributor

sunnylqm commented Sep 19, 2022

No description provided.

@mattcosta7
Copy link
Member

this may be partially fixed in v1.6.0

We still aren't necessarily truncated, but we've removed much of the output, and hope that helps for now!

@nskazki
Copy link
Contributor

nskazki commented Jan 20, 2023

@mattcosta7, I'm in the middle of a big migration, and unfortunately, I'm getting this even on v1.6.0.

Run github/webpack-bundlesize-compare-action@v1.6.0
Error: Validation Failed: {"resource":"IssueComment","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}

@mattcosta7
Copy link
Member

@mattcosta7, I'm in the middle of a big migration, and unfortunately, I'm getting this even on v1.6.0.

Run github/webpack-bundlesize-compare-action@v1.6.0
Error: Validation Failed: {"resource":"IssueComment","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}

Happy to accept prs limiting the output size of the changeset section!

@mattcosta7
Copy link
Member

@mattcosta7, I'm in the middle of a big migration, and unfortunately, I'm getting this even on v1.6.0.

Run github/webpack-bundlesize-compare-action@v1.6.0
Error: Validation Failed: {"resource":"IssueComment","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}

Give the version from #301 a shot. This truncates the output of the changeset section to at most 100 files, and should avoid overflowing the comment max length. We'll work to get that released soon, but you should be able to use that version if you need it!

@t1mwillis
Copy link

@mattcosta7 I can confirm the PR fixes the issue on my end! Thanks 😄

@mattcosta7
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants