Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit changeset to first 100 rows #301

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Limit changeset to first 100 rows #301

merged 5 commits into from
Jan 25, 2023

Conversation

mattcosta7
Copy link
Member

fixes #204

This limits the changeset output to the first 100 rows

additionally, fixes some tsconfig/eslint stuff

@mattcosta7 mattcosta7 requested a review from a team as a code owner January 24, 2023 03:07
@mattcosta7 mattcosta7 self-assigned this Jan 24, 2023
@github-actions
Copy link

github-actions bot commented Jan 24, 2023 •
edited
Loading

Bundle Stats-With chunk and module information

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.98 MB 0%
Changeset
File Δ Size
src/client/this/file/has/a/long/name/so-that-it-will-hopefully-wrap.tsx 🆕 +2.72 KB 0 B -> 2.72 KB
src/client/this-file-was-added.ts 🆕 +1.46 KB 0 B -> 1.46 KB
src/client/this-is-another-file-with-a-long-name-to-test-the-table-sizing.tsx 🆕 +1.04 KB 0 B -> 1.04 KB
src/client/helpers/this-file-is-much-larger.ts 📈 +11.66 KB (+865.77%) 1.35 KB -> 13.01 KB
src/client/this-file-grew-larger.tsx 📈 +200 B (+35.59%) 562 B -> 762 B
src/client/helpers/this-file-grew-smaller.ts 📉 -200 B (-7.94%) 2.46 KB -> 2.26 KB
src/client/this-file-is-much-smaller.tsx 📉 -11.66 KB (-99.92%) 11.67 KB -> 10 B
src/client/routes.tsx 🔥 -2.72 KB (-100%) 2.72 KB -> 0 B
src/client/this-file-will-be-deleted.ts 🔥 -1.46 KB (-100%) 1.46 KB -> 0 B
src/client/render-memex.tsx 🔥 -1.04 KB (-100%) 1.04 KB -> 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
app.bundle.js 1.98 MB 0%
manifest.json 91 B 0%

@github-actions
Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
7 -> 2 1.34 MB -> 1.29 MB (-53.65 KB)
386.44 KB -> N/A (gzip)		 -3.91%
View detailed bundle breakdown

Added

No assets were added

Removed

Asset File Size % Changed
296.chunk.js 124.57 KB -> 0 B (-124.57 KB)
35.05 KB -> 0 B (gzip)		 -100%
288.chunk.js 57.24 KB -> 0 B (-57.24 KB)
16.33 KB -> 0 B (gzip)		 -100%
920.chunk.js 54.98 KB -> 0 B (-54.98 KB)
17.08 KB -> 0 B (gzip)		 -100%
912.chunk.js 44.37 KB -> 0 B (-44.37 KB)
14.31 KB -> 0 B (gzip)		 -100%
699.chunk.js 26.39 KB -> 0 B (-26.39 KB)
6.14 KB -> 0 B (gzip)		 -100%

Bigger

Asset File Size % Changed
app.bundle.js 1.04 MB -> 1.29 MB (+254.35 KB)
297.38 KB -> N/A (gzip)		 +23.91%

Smaller

Asset File Size % Changed
manifest.json 551 B -> 91 B (-460 B)
151 B -> N/A (gzip)		 -83.48%

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats-Flipped around

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 -> 7 1.29 MB -> 1.34 MB (+53.65 KB)
N/A -> 386.44 KB (gzip)		 +4.07%
View detailed bundle breakdown

Added

Asset File Size % Changed
296.chunk.js 0 B -> 124.57 KB (+124.57 KB)
0 B -> 35.05 KB (gzip)		 -
288.chunk.js 0 B -> 57.24 KB (+57.24 KB)
0 B -> 16.33 KB (gzip)		 -
920.chunk.js 0 B -> 54.98 KB (+54.98 KB)
0 B -> 17.08 KB (gzip)		 -
912.chunk.js 0 B -> 44.37 KB (+44.37 KB)
0 B -> 14.31 KB (gzip)		 -
699.chunk.js 0 B -> 26.39 KB (+26.39 KB)
0 B -> 6.14 KB (gzip)		 -

Removed

No assets were removed

Bigger

Asset File Size % Changed
manifest.json 91 B -> 551 B (+460 B)
N/A -> 151 B (gzip)		 +505.49%

Smaller

Asset File Size % Changed
app.bundle.js 1.29 MB -> 1.04 MB (-254.35 KB)
N/A -> 297.38 KB (gzip)		 -19.29%

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats-Non existent

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
0 0 B 0%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats-No changes

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
7 1.34 MB
386.44 KB		 0%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
app.bundle.js 1.04 MB
297.38 KB		 0%
296.chunk.js 124.57 KB
35.05 KB		 0%
288.chunk.js 57.24 KB
16.33 KB		 0%
920.chunk.js 54.98 KB
17.08 KB		 0%
912.chunk.js 44.37 KB
14.31 KB		 0%
699.chunk.js 26.39 KB
6.14 KB		 0%
manifest.json 551 B
151 B		 0%

mattcosta7
mattcosta7 commented Jan 24, 2023
View reviewed changes
__tests__/__snapshots__/main.test.ts.snap
@@ -3,37 +3,37 @@
exports[`Shows stats when files are added 1`] = `
"**Total**

Files count | Type | Total bundle size | % Changed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type was mostly just excessive, so inlining the gzip when necessary, saving on characters

@mattcosta7 mattcosta7 mentioned this pull request Jan 24, 2023
Closed
abigailychen
abigailychen approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@abigailychen abigailychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mattcosta7 mattcosta7 merged commit b761041 into main Jan 25, 2023
@mattcosta7 mattcosta7 deleted the top-100-changeset branch January 25, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abigailychen abigailychen abigailychen approved these changes

Assignees

@mattcosta7 mattcosta7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should truncate output if it's too long
2 participants
@mattcosta7 @abigailychen