Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out assets hidden by Webpack #411

Merged
merged 1 commit into from
Jun 5, 2023
Merged

filter out assets hidden by Webpack #411

merged 1 commit into from
Jun 5, 2023

Conversation

mindtraveller
Copy link
Contributor

@mindtraveller mindtraveller commented Jun 1, 2023

remove empty entries from the stats when Webpack's stats.excludeAssets is used e.g.
image

in the cause above Webpack generates an asset with type 'hidden assets' for all filtered out assets, this PR ignores such assets in stats comparison table

@mindtraveller mindtraveller requested a review from a team as a code owner June 1, 2023 15:00
@mattcosta7
Copy link
Member

mattcosta7 commented Jun 1, 2023

@mindtraveller thanks for this suggested fix! Could you take a few steps here.

  1. Would you mind writing up a PR body for this? I understand the suggested change, but this will be helpful for future context.
  2. In order to build an action, the bundled code is checked in. Could you run npm run all and commit the changed files then push a new commit

I'll try to see about the test being blocked from a fork

@mindtraveller
Copy link
Contributor Author

@mattcosta7 done

@mindtraveller
Copy link
Contributor Author

@mattcosta7 when it's possible to expect this PR being merged and released?

@mattcosta7 mattcosta7 merged commit 78cf2f7 into github:main Jun 5, 2023
@mattcosta7
Copy link
Member

mattcosta7 commented Jun 5, 2023

@mattcosta7 when it's possible to expect this PR being merged and released?

2 minutes ago :-D

https://github.com/github/webpack-bundlesize-compare-action/releases/tag/v1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants