Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch comment header to an h3 #443

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Switch comment header to an h3 #443

merged 1 commit into from
Jul 10, 2023

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jul 8, 2023

The h1 header is very loud in the comment section at the moment. Netlify’s auto comments use an h3 instead of an h1 and it still draws attention without being too annoying.

@j-f1 j-f1 requested a review from a team as a code owner July 8, 2023 19:51
@shiftkey
Copy link
Member

Thanks for the contribution @j-f1. I'm going to leave this open for a bit to figure out why the test suite isn't passing (failures are highly likely to be unrelated to your change).

@j-f1
Copy link
Contributor Author

j-f1 commented Jul 10, 2023

It looks like since my PR comes from a fork the action isn’t allowed to post a comment. I encountered a very similar issue when integrating the check into a repo I help maintain and ended up swapping the workflow to a pull_request_target trigger but that wouldn’t work here since you presumably want to test any code changes.

@shiftkey
Copy link
Member

Looks like this PR only has read access to pull requests, likely due to it coming from a fork as you mentioned.

These permissions seem fine though, perhaps we could run these jobs with a token that does have access to comment here (rather than jumping through all these GITHUB_TOKEN hoops):

permissions:
contents: read
pull-requests: write

@shiftkey
Copy link
Member

Merging this in for now as I see #431 will also have the same issue

@shiftkey shiftkey added this pull request to the merge queue Jul 10, 2023
Merged via the queue into github:main with commit bd465d0 Jul 10, 2023
2 of 3 checks passed
@j-f1 j-f1 deleted the smaller-header branch July 10, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants