[duplicate-code] Duplicate Code Analysis Report - January 2026

[github-actions]

🔍 Duplicate Code Analysis Report

Analysis of commit e36d56f

Summary

This analysis identified 3 significant duplication patterns in the Go codebase that impact maintainability and should be refactored. These patterns represent approximately 60+ lines of duplicated code across critical paths in the server and logging subsystems.

Detected Patterns

1. JSON Unmarshal Argument Parsing - Severity: MEDIUM - See sub-issue [duplicate-code] Duplicate Code Pattern: JSON Unmarshal Argument Parsing #317

   • 3+ instances of identical 8-12 line blocks
   • Located in server/unified.go and testutil packages
   • Direct impact on tool execution paths

2. Markdown Logger Wrapper Functions - Severity: MEDIUM - See sub-issue [duplicate-code] Duplicate Code Pattern: Markdown Logger Wrapper Functions #318

   • 4 nearly identical functions (12-15 lines each)
   • Located in logger/markdown_logger.go
   • 48+ lines of duplicated code

3. RPC Message Logging Duplication - Severity: MEDIUM - See sub-issue [duplicate-code] Duplicate Code Pattern: RPC Message Logging Functions #319

   • 2 functions with identical structure (11-14 lines each)
   • Located in logger/rpc_logger.go
   • Affects all RPC communication logging

Overall Impact

• Total Duplicated Lines: ~60-80 lines
• Affected Files: 5 Go files (server, logger, testutil packages)
• Maintainability Risk: MEDIUM - Changes require updates in multiple locations
• Refactoring Priority: HIGH - Patterns are in frequently called code paths

Next Steps

1. Review individual pattern sub-issues for detailed analysis
2. Prioritize refactoring based on severity and impact (suggest starting with [duplicate-code] Duplicate Code Pattern: Markdown Logger Wrapper Functions #318)
3. Create implementation plan for highest priority patterns
4. Consider extracting common utilities to reduce duplication

Positive Findings

✅ Good patterns already in place:

• Global logger initialization/cleanup properly extracted (internal/logger/global_patterns.go)
• Consistent error wrapping using idiomatic Go patterns
• Appropriate use of mutex locking patterns

Analysis Metadata

• Analyzed Files: 93 Go files (excluding test files)
• Detection Method: Semantic code analysis
• Commit: e36d56f
• Analysis Date: 2026-01-17T10:09:06Z
• Triggered by: @pelikhan