Fix panic in test mock handlers with safe type assertions #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test mock HTTP handlers were panicking on nil type assertions when handling requests without method fields (e.g., SSE heartbeats, connection probes).
Changes
TestCallBackendTool_ReturnsNonNilCallToolResult handler:
require.NoError(err)with error check + HTTP 400 response (line 32)methodfield (line 37-40)TestCallBackendTool_ErrorStillReturnsCallToolResult handler:
method := req["method"].(string)with safe check (line 163-167)Before
After
Both handlers now gracefully reject invalid requests instead of panicking or failing the test.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.