[WIP] Fix CI failure due to runtime-import validation regression #10340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.
Original prompt
This section details on the original issue you should resolve
<issue_title>[CI Failure Doctor] 🏥 CI Failure Investigation - Runtime-import Validation Regression (Run #30032)</issue_title>
<issue_description># 🏥 CI Failure Investigation - Run githubnext/gh-aw#30032
Summary
🚨 CRITICAL: ALL CI BUILDS BLOCKED - PR #10312 introduced compile-time validation for
runtime-importexpressions that breaks lock file compilation, preventing any PRs from being merged.Failure Details
75ce58e28a9d3cb12b500deec165c21d659d19d7pushto main branchRoot Cause Analysis
PR #10312 added a new validation step
validateRuntimeImportFiles()in the compiler that validates GitHub Actions expressions in runtime-imported markdown files at compile time. This validation is failing when rebuilding lock files, causing the CI build job to fail.Files Changed in PR #10312
pkg/workflow/compiler.go (+19 lines)
validateRuntimeImportFiles()call during compilation.github/workflows/file.mdpkg/workflow/expression_validation.go (+117 lines)
validateRuntimeImportFiles()functionextractRuntimeImportPaths()helper functionpkg/workflow/runtime_import_validation_test.go (+323 lines)
Suspected Issue
Two workflows use
runtime-importto include files from.github/agentics/:{{#runtime-import agentics/code-simplifier.md}}{{#runtime-import agentics/repo-audit-analyzer.md}}These imported files contain GitHub Actions expressions like:
${{ github.repository }}✅ In AllowedExpressions list${{ github.workspace }}✅ In AllowedExpressions list${{ inputs.repository || 'FStarLang/FStar' }}❓ Should be allowed viainputs.*patternPossible root causes:
.github/agentics/files||) in expressions may not be handled correctlyFailed Jobs and Errors
Build Job (FAILED)
Subsequent Jobs (CANCELLED)
Note: Unable to access full error logs without GitHub API authentication.
Investigation Findings
Validation Logic Flow
Files That Should Exist
✅
.github/agentics/code-simplifier.md- EXISTS (confirmed)✅
.github/agentics/repo-audit-analyzer.md- EXISTS (confirmed)Expressions Found in Imported Files
From code-simplifier.md:
From repo-audit-analyzer.md:
${{ inputs.repository || 'FStarLang/FStar' }}All these expressions should be valid according to the allowlist.
Recommended Actions
🔥 IMMEDIATE (Fix CI)
Reproduce Locally:
git checkout 75ce58e28a9d3cb12b500deec165c21d659d19d7 make build make recompile # Should fail on code-simplifier.md or repo-audit-analyzer.mdGet Actual Error Message: The CI logs will show the exact validation error
Quick Fix Options:
.github/agentics/subdirectory🔧 ROOT CAUSE FIX
Based on the actual error message, fix one of:
workspaceDircalculation works in CI environment||,&&)inputs.*regex matchesinputs.repository✅ V...
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.