-
Notifications
You must be signed in to change notification settings - Fork 36
fix: move views configuration from update-project to create-project in campaign generator #10748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
@copilot Also fix in source that creates these files |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Updated the source instruction file |
|
@copilot This change belongs here: |
…orSafeOutputs Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Fixed in |
|
@copilot Recompile and fix tests. |
…ate-project Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Recompiled workflow and fixed all related issues:
All tests now pass. (747a20c) |
Investigation: Campaign Generator Views Not Created
Problem Analysis
The campaign generator workflow did not create the three configured views on the project. Analysis of workflow run #21150028596 reveals:
Root Cause: Views configuration was under
update-projectinstead ofcreate-projectin multiple placesKey Findings
create_project,add_comment,assign_to_agentupdate-projectbut should be undercreate-projectcreate_project.cjsandupdate_project.cjshandlers support views configurationpkg/campaign/generator.gopkg/cli/init.goSolution
1. Fixed workflow configuration - Moved views from
update-projecttocreate-projectsection in.github/workflows/agentic-campaign-generator.md2. Updated source instruction file - Added text documentation in
.github/aw/generate-agentic-campaign.mdshowing the correct safe-outputs configuration (without code examples that would fail validation)3. Fixed programmatic source - Updated
buildGeneratorSafeOutputs()inpkg/campaign/generator.goto place views underCreateProjectsinstead ofUpdateProjects4. Fixed rendering function - Updated
renderCampaignGeneratorMarkdown()inpkg/cli/init.goto output views undercreate-projectinstead ofupdate-project5. Fixed tests - Updated test expectations to match the correct description format
The
create_projecthandler is designed to create views automatically after project creation (seepkg/workflow/create_project.go:13). Theupdate_projecthandler is for updating existing projects with new views.Files Changed
.github/workflows/agentic-campaign-generator.md- Fixed views configuration.github/workflows/agentic-campaign-generator.lock.yml- Recompiled with fix.github/aw/generate-agentic-campaign.md- Added text documentation showing correct configurationpkg/campaign/generator.go- Fixed programmatic source for workflow generationpkg/cli/init.go- Fixed markdown rendering to output views under create-projectpkg/cli/init_test.go- Updated test expectationsVerification
The compiled lock file now correctly includes views in the
create_projectconfiguration. When the workflow runs next time, thecreate_projecthandler will automatically create all three views after creating the project. The programmatic source now ensures that any regeneration of the workflow file usinggh aw init --campaignwill also have the correct configuration.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.