Type Playwright tool configuration arrays

[Copilot]

Replaces []any in Playwright tool configuration with strongly-typed slices, eliminating type assertions throughout the codebase.

Changes

New types (pkg/workflow/tools_types.go):

• PlaywrightDomain and PlaywrightAllowedDomains with ToStringSlice() method
• PlaywrightToolConfig.AllowedDomains changed from []string to PlaywrightAllowedDomains

Parser enhancement (pkg/workflow/tools_parser.go):

• parsePlaywrightTool() now handles numeric version formats and both []any / []string args
• Returns *PlaywrightToolConfig directly, no type assertions needed

Function signatures updated (11 files):

// Before
func generatePlaywrightDockerArgs(playwrightTool any) PlaywrightDockerArgs

// After  
func generatePlaywrightDockerArgs(playwrightConfig *PlaywrightToolConfig) PlaywrightDockerArgs

Applied to: generatePlaywrightAllowedDomains, getPlaywrightCustomArgs, getPlaywrightDockerImageVersion, getPlaywrightMCPPackageVersion, and all render functions.

Call sites (mcp_servers.go, mcp_renderer.go, mcp-config-playwright.go):

• Parse configuration at entry point: playwrightConfig := parsePlaywrightTool(playwrightTool)
• Pass typed config to downstream functions

Tests updated (5 files):

• All test fixtures now parse before passing to functions

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[plan] Type Playwright tool configuration arrays</issue_title>
<issue_description>## Objective

Replace []any usage in Playwright tool configuration with strongly-typed slices for allowed domains and other configuration arrays.

Context

From discussion #10816: The Playwright tool configuration uses []any for configuration arrays, requiring type assertions. This affects domain allowlists and other array-based configuration.

Approach

1. Define semantic types in pkg/workflow/tools_types.go:

   type PlaywrightDomain string
   type PlaywrightAllowedDomains []PlaywrightDomain
   // Add other Playwright-specific types as needed

2. Update PlaywrightToolConfig struct to use typed slices:

   • Change domain allowlist field to use PlaywrightAllowedDomains
   • Update other array fields in Playwright configuration

3. Update Playwright tool parsing in pkg/workflow/tools_parser.go:

   • Remove type assertions for domain lists
   • Use direct type conversion from YAML

4. Update code that validates and uses Playwright configuration:

   • Search for Playwright tool usage in pkg/workflow/
   • Remove type assertion logic

5. Update test fixtures

Files to Modify

• Update: pkg/workflow/tools_types.go (add Playwright semantic types)
• Update: pkg/workflow/tools_parser.go (update Playwright parsing)
• Update: Files that validate or use Playwright configuration
• Update: Test files with Playwright tool fixtures

Acceptance Criteria

• Semantic types for Playwright domains are defined
• PlaywrightToolConfig uses typed slices instead of []any
• Type assertions for Playwright arrays are eliminated
• All existing tests pass
• Run make agent-finish successfully before committing

AI generated by Plan Command for discussion #10816

Comments on the Issue (you are @copilot in this section)

• Fixes [plan] Type Playwright tool configuration arrays #10828

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.