Skip to content

Replace base64 encoding with %q formatting and add CodeQL suppression #11402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jan 22, 2026
Merged

Replace base64 encoding with %q formatting and add CodeQL suppression #11402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eda35e8
Initial plan
Copilot Jan 22, 2026
f286660
fix: replace base64 encoding with %q formatting and add CodeQL suppre…
Copilot Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions pkg/workflow/update_project_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package workflow

import (
"encoding/base64"
"encoding/json"
"fmt"
)
Expand Down Expand Up @@ -45,11 +44,11 @@ func (c *Compiler) buildUpdateProjectJob(data *WorkflowData, mainJobName string)
if err != nil {
return nil, fmt.Errorf("failed to marshal views configuration: %w", err)
}
// Encode JSON as base64 to avoid quote-escaping vulnerabilities
// Base64 encoding ensures the value contains no special characters that could break out
// of quotes in downstream processing (shell commands, SQL queries, etc.)
viewsBase64 := base64.StdEncoding.EncodeToString(viewsJSON)
customEnvVars = append(customEnvVars, fmt.Sprintf(" GH_AW_PROJECT_VIEWS: %s\n", viewsBase64))
// lgtm[go/unsafe-quoting] - This generates YAML environment variable declarations, not shell commands.
// The %q format specifier properly escapes the JSON string for YAML syntax. There is no shell injection
// risk because this value is set as an environment variable in the GitHub Actions YAML configuration,
// not executed as shell code.
customEnvVars = append(customEnvVars, fmt.Sprintf(" GH_AW_PROJECT_VIEWS: %q\n", string(viewsJSON)))
}

jobCondition := BuildSafeOutputType("update_project")
Expand Down
Loading