Add HTTP transport capability validation and time MCP server for agentic engines #19

Copilot · 2025-08-13T00:36:50Z

This PR expands the original MCP server support implementation to include HTTP transport capability validation for different agentic engines, addressing the limitation that some engines only support stdio transport. Additionally, it enhances the test-codex workflow with a time MCP server for timestamping functionality.

Key Changes

1. HTTP Transport Capability System

Added a new engine capability SupportsHTTPTransport() to track which engines support HTTP MCP servers:

Codex: Only supports stdio transport (set to false)
Claude: Supports both stdio and HTTP transport (set to true)
Gemini: Only supports stdio for custom MCP servers (set to false)

2. Enhanced CLI Display

Updated the engine listing to show HTTP transport capabilities:

ID              Display Name         Status       MCP      HTTP Transport
--              ------------         ------       ---      -------------
claude          Claude Code          Stable       Yes      Yes         
codex           Codex                Experimental Yes      No          
gemini          Gemini CLI           Stable       Yes      No

3. Compiler Validation

Added validation in the workflow compiler to prevent HTTP MCP server configurations when the engine doesn't support them:

---
engine: codex  # Only supports stdio
tools:
  custom-server:
    mcp:
      type: "http"  # This will now be rejected
      url: "http://localhost:3000"
---

Results in: tool 'custom-server' uses HTTP transport which is not supported by engine 'codex' (only stdio transport is supported)

4. Enhanced Test Codex Workflow

Added comprehensive MCP server support to the test-codex workflow using best practices for container configuration:

tools:
  time:
    mcp:
      type: stdio
      container: "mcp/time"
      env:
        LOCAL_TIMEZONE: "${LOCAL_TIMEZONE}"
    allowed: ["get_current_time"]

Time MCP Server: Container-based time server for timestamping analysis
get_current_time Tool: Enabled for timestamping workflow execution
Updated Prompt: Modified to request current time at analysis start
Enhanced Output: Added timestamp field to PR summary template
Proper Container Configuration: Uses the documented container field for clean Docker configuration

5. Maintained Original Features

All original MCP functionality remains intact:

History configuration for Codex (persistence = "none")
Full MCP server support with supportsToolsWhitelist: true
Proper TOML configuration generation
Backward compatibility with existing workflows

6. Testing

All existing tests continue to pass
New validation correctly rejects unsupported configurations
HTTP transport works correctly with compatible engines (Claude)
Time MCP server configuration compiles correctly for Codex using proper container field
Container field properly transforms to Docker command structure in generated TOML

This ensures that workflows fail fast with clear error messages when attempting to use HTTP MCP servers with engines that only support stdio transport, while providing enhanced functionality for timestamp-aware workflow execution using best practices for container configuration.

Fixes #18.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Enable MCP tools whitelist support for Codex engine - Add history configuration with persistence=none to config.toml - Update engine description to reflect MCP support - Add comprehensive tests for custom MCP servers with Codex - Validate config.toml generation includes history and MCP sections - Ensure compatibility with existing Claude and Gemini engines Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2025-08-13T02:12:13Z

pkg/workflow/codex_test.go

+      command: "python"
+      args: ["-m", "my_server"]
+      env:
+        API_KEY: "{{ secrets.API_KEY }}"


@copilot missing $

Fixed in commit 1ea81dc. The missing $ has been added to both the test input and assertion to use the correct GitHub Actions template syntax: ${{ secrets.API_KEY }}.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-08-13T02:29:38Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build1463307643/b255/cli.test -test.testlogfile=/tmp/go-build1463307643/b255/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pelikhan · 2025-08-13T02:48:47Z

@copilot OpenAI codex only supports stdio transport for mcp servers.

Add a agentic engine capability for http transport support and set it to false for codex.
update other engines
add a configuration validation in the compiler to refuse http MCP server configurations when not supported by the engine.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-08-13T03:08:55Z

@copilot OpenAI codex only supports stdio transport for mcp servers.

Add a agentic engine capability for http transport support and set it to false for codex.

update other engines ...

I've implemented all the requested changes in commit 45e3d53:

Added HTTP transport capability - New SupportsHTTPTransport() method in the agentic engine interface
Set capabilities per engine:
- Codex: supportsHTTPTransport = false (only stdio transport)
- Claude: supportsHTTPTransport = true (both stdio and HTTP)
- Gemini: supportsHTTPTransport = false (only stdio for custom MCP)
Updated CLI display - Replaced "Node.js" column with "HTTP Transport" showing each engine's capabilities
Added compiler validation - HTTP MCP servers are now rejected with clear error messages when used with engines that don't support them

The validation works correctly:

Codex with HTTP MCP: ❌ tool 'custom-server' uses HTTP transport which is not supported by engine 'codex' (only stdio transport is supported)
Claude with HTTP MCP: ✅ Compiles successfully
Gemini with HTTP MCP: ❌ Same error as Codex

All existing tests pass and the new functionality is working as requested.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build1193402773/b255/cli.test -test.testlogfile=/tmp/go-build1193402773/b255/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
- Triggering command: /tmp/go-build2581049781/b255/cli.test -test.testlogfile=/tmp/go-build2581049781/b255/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pelikhan · 2025-08-13T03:34:16Z

.

pelikhan · 2025-08-13T03:34:53Z

@copilot - Update the test-codex.yml with a simple mcp stdio server

{
"mcpServers": {
"time": {
"command": "docker",
"args": ["run", "-i", "--rm", "-e", "LOCAL_TIMEZONE", "mcp/time"]
}
}
}

Update test-codex.yml to allow the get_current_time tool
update prompt to request the current time

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-08-13T03:42:07Z

@copilot - Update the test-codex.yml with a simple mcp stdio server

{...

I've implemented all the requested changes in commit ad97bf3:

Added time MCP server with stdio transport using the specified Docker configuration:

tools:
  time:
    mcp:
      type: stdio
      command: "docker"
      args: ["run", "-i", "--rm", "-e", "LOCAL_TIMEZONE", "mcp/time"]
    allowed: ["get_current_time"]

Enabled get_current_time tool in the allowed tools list for the time MCP server
Updated prompt to request current time at the start:
- Added instruction: "First, get the current time using the get_current_time tool to timestamp your analysis"
- Added "Analysis Time" field to the PR summary template

The workflow now compiles correctly and generates the proper TOML configuration with both the GitHub MCP server (for repository operations) and the time MCP server (for timestamping). All tests continue to pass.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build878271565/b255/cli.test -test.testlogfile=/tmp/go-build878271565/b255/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pelikhan · 2025-08-13T03:57:21Z

.github/workflows/test-codex.md

+  time:
+    mcp:
+      type: stdio
+      command: "docker"


@copilot use the "container" field to configure this MCP server (see docs)

Updated in commit dfcff98. Changed to use the container field as documented instead of manual Docker command configuration. The time MCP server now uses proper container-based setup that automatically generates the correct Docker command structure.

…orkflow Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-08-13T04:12:28Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build2430576817/b255/cli.test -test.testlogfile=/tmp/go-build2430576817/b255/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
- Triggering command: /tmp/go-build2937509441/b255/cli.test -test.testlogfile=/tmp/go-build2937509441/b255/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ck files in CI workflow

github-actions · 2025-08-13T04:38:02Z

🤖 Codex PR Summary

Branch: copilot/fix-18
Files Changed: 11 files
Analysis Time: 2025-08-13T04:36:27Z

📋 Change Overview

Adds HTTP transport capability and validation for agentic engines.
Introduces time MCP server for timestamping analyses.
Type of changes: feature, refactor, tests.

📁 Files Modified

.github/workflows/ci.yml (Modified): Adds check for generated lock file changes.
.github/workflows/test-codex.lock.yml (Modified): Inserts history persistence setting; adds time MCP server config; reorders env vars.
.github/workflows/test-codex.md (Modified): Mirrors lock workflow changes; enables get_current_time tool.
pkg/cli/commands.go (Modified): Extends engine listing table to include HTTP transport column.
pkg/workflow/agentic_engine.go (Modified): Adds SupportsHTTPTransport method to interface and base struct.
pkg/workflow/claude_engine.go (Modified): Enables HTTP transport support for Claude engine.
pkg/workflow/codex_engine.go (Modified): Updates description; enables tool whitelist; sets HTTP transport to false; injects history config.
pkg/workflow/codex_engine_test.go (Modified): Corrects test assertion for tool whitelist support.
pkg/workflow/codex_test.go (Modified): Adds tests for history persistence and custom MCP server scenarios.
pkg/workflow/compiler.go (Modified): Adds HTTP transport validation; sorts environment keys for consistency.
pkg/workflow/gemini_engine.go (Modified): Disables HTTP transport support for Gemini engine.

🔍 Key Changes

Tracks HTTP transport capability per engine and surfaces it in CLI.
Compiler now rejects HTTP MCP servers when engine lacks support.
Adds time-based MCP server in test workflows using proper container configuration.

🎯 Recommendations

Update repository documentation for HTTP transport support and configuration.
Add integration tests covering HTTP transport paths across engines.
Review readme to include new CLI table column.
Confirm existing workflows still compile without HTTP MCP configs.

🔗 Related

Fixes openai codex mcp server #18

AI-generated content by Test Codex may contain mistakes.

Replace single-quote string formatting with %q format specifier to properly escape user-controlled input in error messages. This prevents potential quote injection vulnerabilities where malicious YAML key names containing single quotes could break out of the string literal. Security Impact: - Prevents potential command injection or SQL injection if error messages are used in contexts that interpret quotes specially - Follows Go best practices for safely embedding untrusted data in strings Changes: - Changed format string from '%s' to %q in validateExpressionSizes function - The %q specifier automatically escapes special characters including quotes Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Replace single-quote string formatting with %q format specifier to properly escape user-controlled input in error messages. This prevents potential quote injection vulnerabilities where malicious YAML key names containing single quotes could break out of the string literal. Security Impact: - Prevents potential command injection or SQL injection if error messages are used in contexts that interpret quotes specially - Follows Go best practices for safely embedding untrusted data in strings Changes: - Changed format string from '%s' to %q in validateExpressionSizes function - The %q specifier automatically escapes special characters including quotes Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Security Fix PR <github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>

Initial plan

4cc43a0

Copilot AI assigned Copilot and pelikhan Aug 13, 2025

Copilot started work on behalf of pelikhan August 13, 2025 00:36 View session

Copilot AI changed the title ~~[WIP] code mcp server~~ Add MCP server support and history configuration for Codex engine Aug 13, 2025

Copilot finished work on behalf of pelikhan August 13, 2025 01:00

Copilot AI requested a review from pelikhan August 13, 2025 01:00

Merge branch 'main' into copilot/fix-18

3db2c58

pelikhan reviewed Aug 13, 2025

View reviewed changes

Copilot started work on behalf of pelikhan August 13, 2025 02:13 View session

Fix missing $ in GitHub Actions template syntax for secrets

1ea81dc

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI requested a review from pelikhan August 13, 2025 02:29

Copilot finished work on behalf of pelikhan August 13, 2025 02:29

Copilot started work on behalf of pelikhan August 13, 2025 02:48 View session

Add HTTP transport support capability and validation for agentic engines

45e3d53

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~Add MCP server support and history configuration for Codex engine~~ Add HTTP transport capability and validation for MCP servers in agentic engines Aug 13, 2025

Copilot finished work on behalf of pelikhan August 13, 2025 03:09

Copilot started work on behalf of pelikhan August 13, 2025 03:35 View session

Add time MCP server and get_current_time tool to test-codex workflow

ad97bf3

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~Add HTTP transport capability and validation for MCP servers in agentic engines~~ Add HTTP transport capability validation and time MCP server for agentic engines Aug 13, 2025

Copilot finished work on behalf of pelikhan August 13, 2025 03:43

pelikhan reviewed Aug 13, 2025

View reviewed changes

Copilot started work on behalf of pelikhan August 13, 2025 03:57 View session

Use container field for time MCP server configuration in test-codex w…

dfcff98

…orkflow Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI requested a review from pelikhan August 13, 2025 04:12

Copilot finished work on behalf of pelikhan August 13, 2025 04:12

pelikhan marked this pull request as ready for review August 13, 2025 04:20

pelikhan added 4 commits August 13, 2025 04:26

Add check for changes in generated lock files in CI workflow

aa66ce8

Fix git status command for checking generated lock files in CI workflow

b9f7cc3

Replace git status with git diff to check for changes in generated lo…

7a1d6bb

…ck files in CI workflow

Sort environment variables in generated YAML for consistent output

677eeeb

pelikhan merged commit 0d8250d into main Aug 13, 2025
9 checks passed

pelikhan deleted the copilot/fix-18 branch August 13, 2025 04:39

github-actions bot mentioned this pull request Oct 14, 2025

[security-fix] Security Fix: Unsafe quoting in validation error messages (Alert #19) #1703

Merged

github-actions bot mentioned this pull request Dec 17, 2025

[ci-coach] Optimize integration test matrix by rebalancing CLI test groups #6736

Closed

4 tasks

github-actions bot mentioned this pull request Jan 14, 2026

[P1] Metrics Collector Failing - MCP Gateway Schema Validation Error #9898

Closed

Copilot AI mentioned this pull request Jan 14, 2026

Fix MCP Gateway v0.0.47+ schema validation in metrics-collector workflow #9903

Merged

Add HTTP transport capability validation and time MCP server for agentic engines #19

Add HTTP transport capability validation and time MCP server for agentic engines #19

Uh oh!

Conversation

Copilot AI commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Key Changes

1. HTTP Transport Capability System

2. Enhanced CLI Display

3. Compiler Validation

4. Enhanced Test Codex Workflow

5. Maintained Original Features

6. Testing

Uh oh!

pelikhan Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Aug 13, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

pelikhan commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

pelikhan commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Aug 13, 2025

Uh oh!

Copilot AI commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

pelikhan Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Aug 13, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions bot commented Aug 13, 2025

🤖 Codex PR Summary

📋 Change Overview

📁 Files Modified

🔍 Key Changes

🎯 Recommendations

🔗 Related

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Aug 13, 2025 •

edited

Loading

pelikhan commented Aug 13, 2025 •

edited

Loading

Copilot AI commented Aug 13, 2025 •

edited

Loading

pelikhan commented Aug 13, 2025 •

edited

Loading

Copilot AI commented Aug 13, 2025 •

edited

Loading