-
Notifications
You must be signed in to change notification settings - Fork 36
Add support for top-level github-token configuration in workflow frontmatter
#1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ontmatter Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for github-token in front matter
Add support for top-level Oct 18, 2025
github-token configuration in workflow frontmatter
pelikhan
reviewed
Oct 18, 2025
pkg/workflow/compiler.go
Outdated
| // 1. Custom token passed as parameter (e.g., from safe-outputs) | ||
| // 2. Top-level github-token from frontmatter | ||
| // 3. Default fallback: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} | ||
| func getEffectiveGitHubToken(customToken, toplevelToken string) string { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot move to github_token.go
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to pkg/workflow/github_token.go in commit 3f5e8ac
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for top-level
github-tokenfield in frontmatterPlan
github-tokenfield at top levelSummary
Successfully implemented top-level
github-tokenfield with complete precedence hierarchy:github-token(highest priority) - e.g.,create-issue.github-tokengithub-token- e.g.,safe-outputs.github-tokengithub-token(new) - e.g.,github-token: ${{ secrets.CUSTOM_PAT }}${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }}Recent Changes
getEffectiveGitHubToken()helper function to newgithub_token.gofile for better code organizationKey Features
Testing
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.