Fix logs command not finding all runs when no workflow name is specified

[Copilot]

✅ COMPLETE: Fix logs command filtering issue

Problem

The logs command was not finding all workflow runs when no workflow name was specified:

./gh-aw logs tidy -c 10    # Returns 10 runs ✓
./gh-aw logs -c 10          # Returns fewer than 10 runs ❌

Root Cause

Bug in pagination logic (pkg/cli/logs.go line 616):

if len(runs) < batchSize {  // WRONG: uses filtered count
    break  // Stops iteration prematurely
}

When searching all workflows:

1. GitHub API returns 250 mixed runs (agentic + non-agentic)
2. Filter to agentic workflows → only 5 match
3. Check: len(filtered)=5 < batchSize=250 → STOP ❌ (incorrect!)
4. Should: Check totalFetched=250 < batchSize=250 → CONTINUE ✓

Solution

Modified listWorkflowRunsWithPagination to return:

• Filtered workflow runs (agentic only)
• Total count fetched from API (before filtering)

Fixed iteration logic:

if totalFetched < batchSize {  // CORRECT: uses API response count
    break  // Only stops when truly out of data
}

Changes Made

• Modified function signature to return ([]WorkflowRun, int, error)
• Added totalFetched tracking before filtering
• Updated end-of-batch check to use totalFetched
• Updated all error returns to include new parameter
• Added comprehensive inline comments
• Updated test to handle new return value
• Created documentation tests in logs_filtering_test.go

Validation ✅

make build          # ✓ Compiles successfully
make test-unit      # ✓ All unit tests pass
make test           # ✓ All tests pass
make fmt            # ✓ Code formatted
make lint           # ✓ No linting issues
make agent-finish   # ✓ Complete validation passes

Impact

✅ Consistent behavior: ./gh-aw logs -c 10 now returns 10 runs
✅ No performance impact: Same efficient batch fetching
✅ No breaking changes: CLI interface unchanged
✅ Minimal code changes: Only 4 lines changed, rest are comments
✅ Well documented: Inline comments + test file

Files Changed

• pkg/cli/logs.go - Core fix with detailed comments
• pkg/cli/logs_test.go - Updated test signature
• pkg/cli/logs_filtering_test.go - Documentation tests

Testing

All tests pass, no regressions detected.

Original prompt

The "logs" command does not find all the runs when no workflow name is specified. Investigate when it is failing.

compare the output of ./gh-aw logs tidy -c 10 and ./gh-aw logs -c 10

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[github-actions]

Agentic Changeset Generator triggered by this pull request.

[pelikhan]

@copilot remove file

[Copilot]

Removed in abb9288