Safe discussions, pull request reviews and better errors #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd validation support (#43) * Initial plan * Add create-discussion safe output type Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Convert create-discussion from GraphQL to REST API and remove discussions:write permission requirement Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add create-discussion validation support to collect_ndjson_output.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Revert package-lock.json name change from gh-aw-copilots back to gh-aw Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>
…erated malformed JSON (#42) * Initial plan * Implement JSON repair capabilities for safe-output JSONL parser Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add comprehensive test coverage for JSON repair functionality - Added 16 new test cases covering various JSON repair scenarios - Tests include mixed quote types, bracket issues, Unicode chars, complex nesting - Added graceful failure tests for edge cases beyond repair capabilities - All 190 JavaScript tests now pass, including 41 JSONL parser tests - Tests validate robustness of LLM-generated JSON handling Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Improve JSON parsing error handling: print to console and return undefined instead of throwing exceptions Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Refactor JSON parsing logic: streamline error handling and improve validation for output types * Add JSON repair and parsing functions to handle malformed input * Fix test cases for JSON repair functionality Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>
…nsive validation (#44)
… and Codex workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.