Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 4, 2025

  • Update Security Considerations section to add subsection on security scanning tools
  • Document actionlint (with shellcheck integration)
  • Document zizmor security scanner
  • Document poutine security scanner
  • Add examples of running security scanners with compile command
  • Update Best Practices section to include security scanner recommendations
  • Update Compilation Commands section to include all scanner flags
  • Make documentation much more concise (reduced from ~190 lines to ~20 lines)
Original prompt

Update GitHub agentic workflow instructions file section on security best practices

  • actionlint shellcheck, poutine and zizmor rules
  • how to run --actionlint --zizmor --poutine checks

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Document actionlint with shellcheck integration for GitHub Actions linting
- Document zizmor security scanner for vulnerability detection
- Document poutine for supply chain security analysis
- Add detailed usage examples and command-line flags
- Include common rules, exit codes, and best practices
- Update compilation commands to include --actionlint flag
- Update best practices to recommend all three scanners

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update workflow instructions for security best practices Document security scanning tools in agentic workflow instructions Nov 4, 2025
Copilot AI requested a review from pelikhan November 4, 2025 02:24
Copy link
Contributor

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot much much more concise, shorter to the point

Reduced from ~190 lines to ~20 lines while maintaining essential information:
- Combined three scanner descriptions into brief one-liners
- Kept core usage examples and commands
- Simplified exit codes to single line
- Removed verbose features, configuration, example outputs sections

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 4, 2025

@copilot much much more concise, shorter to the point

Condensed from ~190 lines to ~20 lines in commit 5400277. Removed verbose features/configuration/example sections while keeping essential usage and exit codes.

Copilot AI requested a review from pelikhan November 4, 2025 02:35
@pelikhan pelikhan marked this pull request as ready for review November 4, 2025 02:36
Copilot AI review requested due to automatic review settings November 4, 2025 02:36
@pelikhan pelikhan merged commit 27b9951 into main Nov 4, 2025
6 checks passed
@pelikhan pelikhan deleted the copilot/update-security-best-practices branch November 4, 2025 02:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the actionlint security scanning tool to the GitHub Agentic Workflows instructions, expanding the existing security scanning capabilities.

  • Adds a new "Security Scanning Tools" section documenting --actionlint, --zizmor, and --poutine flags
  • Updates the compile command reference to include the --actionlint flag
  • Updates best practices to recommend all three security scanners

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/cli/templates/github-agentic-workflows.instructions.md Adds Security Scanning Tools section and updates compile command documentation with actionlint support
.github/instructions/github-agentic-workflows.instructions.md Mirrors the same documentation changes as the template file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GitHub Agentic Workflows supports security scanning during compilation with `--actionlint`, `--zizmor`, and `--poutine` flags.

**actionlint** - Lints GitHub Actions workflows and validates shell scripts with integrated shellcheck
**zizmor** - Scans for security vulnerabilities, privilege escalation, and secret exposure
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace at the end of line 1045.

Suggested change
**zizmor** - Scans for security vulnerabilities, privilege escalation, and secret exposure
**zizmor** - Scans for security vulnerabilities, privilege escalation, and secret exposure

Copilot uses AI. Check for mistakes.
GitHub Agentic Workflows supports security scanning during compilation with `--actionlint`, `--zizmor`, and `--poutine` flags.

**actionlint** - Lints GitHub Actions workflows and validates shell scripts with integrated shellcheck
**zizmor** - Scans for security vulnerabilities, privilege escalation, and secret exposure
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace at the end of line 1045.

Suggested change
**zizmor** - Scans for security vulnerabilities, privilege escalation, and secret exposure
**zizmor** - Scans for security vulnerabilities, privilege escalation, and secret exposure

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants