Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 4, 2025

The build job was running on both Ubuntu and macOS via matrix strategy. This removes the matrix and runs only on Ubuntu.

Changes

  • Removed strategy.matrix section with os: [ubuntu-latest, macos-latest]
  • Changed runs-on: ${{ matrix.os }} to runs-on: ubuntu-latest
  • Simplified concurrency group by removing ${{ matrix.os }} reference

This reduces the build job from 2 parallel runners to 1, cutting CI time and resource usage in half for this job.

Original prompt

Update ci.yml

  • remove matrix in build job and only runs for ubuntu

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review November 4, 2025 15:29
Copilot AI review requested due to automatic review settings November 4, 2025 15:29
Copilot AI changed the title [WIP] Update ci.yml to remove matrix and run only on Ubuntu Remove matrix strategy from CI build job Nov 4, 2025
Copilot AI requested a review from pelikhan November 4, 2025 15:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the CI workflow by removing multi-OS build testing. The build job now runs only on Ubuntu instead of running on both Ubuntu and macOS via a matrix strategy.

  • Removed the matrix strategy configuration for the build job
  • Changed runs-on from using matrix.os to hardcoded ubuntu-latest
  • Updated concurrency group to no longer include the OS matrix variable
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:72

  • Removing macOS from the build matrix eliminates cross-platform build validation. The test and js jobs depend on build (line 11, 72) and will no longer verify compatibility on macOS. Consider if this is intentional or if macOS build coverage should be preserved in a separate job.
    needs: build

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pelikhan pelikhan merged commit eacae9c into main Nov 4, 2025
43 of 44 checks passed
@pelikhan pelikhan deleted the copilot/update-ci-yml-ubuntu-only branch November 4, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants