Evaluate performance enhancements in integration test caching #3152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Optimize integration test binary to reduce execution time
Evaluate performance enhancements in integration test caching
Nov 4, 2025
Contributor
|
@copilot remove sync once as commented above |
TestMain runs exactly once before all tests, making the sync.Once wrapper redundant. Simplified by moving build logic directly into TestMain body. Changes: - Removed sync.Once import and globalBinaryOnce variable - Moved binary build logic directly into TestMain (no wrapper) - Zero functional changes - all tests still pass - Maintains same performance benefits Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Removed Changes in 9b4dd0c:
|
pelikhan
approved these changes
Nov 4, 2025
pelikhan
merged commit 416e1f1
into
perf/cache-integration-test-binary-36ba5d908f6693f1
25 of 30 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync.Oncewrapper per code reviewTestMainby moving build logic directly into function body💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.