Skip to content

Evaluate performance enhancements in integration test caching #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Nov 4, 2025
Merged

Evaluate performance enhancements in integration test caching #3152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a63bd88
Initial plan
Copilot Nov 4, 2025
9b4dd0c
refactor: remove unnecessary sync.Once wrapper in TestMain
Copilot Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 22 additions & 27 deletions pkg/cli/compile_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"os/exec"
"path/filepath"
"strings"
"sync"
"testing"
"time"

Expand All @@ -19,7 +18,6 @@ import (
// Global binary path shared across all integration tests
var (
globalBinaryPath string
globalBinaryOnce sync.Once
projectRoot string
)

Expand All @@ -32,35 +30,32 @@ func TestMain(m *testing.M) {
}
projectRoot = filepath.Join(wd, "..", "..")

// Build the binary once for all tests
globalBinaryOnce.Do(func() {
// Create temp directory for the shared binary
tempDir, err := os.MkdirTemp("", "gh-aw-integration-binary-*")
if err != nil {
panic("Failed to create temp directory for binary: " + err.Error())
}
// Create temp directory for the shared binary
tempDir, err := os.MkdirTemp("", "gh-aw-integration-binary-*")
if err != nil {
panic("Failed to create temp directory for binary: " + err.Error())
}

globalBinaryPath = filepath.Join(tempDir, "gh-aw")
globalBinaryPath = filepath.Join(tempDir, "gh-aw")

// Build the gh-aw binary
buildCmd := exec.Command("make", "build")
buildCmd.Dir = projectRoot
buildCmd.Stderr = os.Stderr
if err := buildCmd.Run(); err != nil {
panic("Failed to build gh-aw binary: " + err.Error())
}
// Build the gh-aw binary
buildCmd := exec.Command("make", "build")
buildCmd.Dir = projectRoot
buildCmd.Stderr = os.Stderr
if err := buildCmd.Run(); err != nil {
panic("Failed to build gh-aw binary: " + err.Error())
}

// Copy binary to temp directory
srcBinary := filepath.Join(projectRoot, "gh-aw")
if err := copyFile(srcBinary, globalBinaryPath); err != nil {
panic("Failed to copy gh-aw binary to temp directory: " + err.Error())
}
// Copy binary to temp directory
srcBinary := filepath.Join(projectRoot, "gh-aw")
if err := copyFile(srcBinary, globalBinaryPath); err != nil {
panic("Failed to copy gh-aw binary to temp directory: " + err.Error())
}

// Make the binary executable
if err := os.Chmod(globalBinaryPath, 0755); err != nil {
panic("Failed to make binary executable: " + err.Error())
}
})
// Make the binary executable
if err := os.Chmod(globalBinaryPath, 0755); err != nil {
panic("Failed to make binary executable: " + err.Error())
}

// Run the tests
code := m.Run()
Expand Down
Loading