Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/test-safe-outputs-custom-engine.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ gh aw version
## Validation and Testing

### Manual Functionality Testing
**CRITICAL**: After making any changes, always validate functionality with these steps:
**CRITICAL**: After making any changes, always build the compiler, and validate functionality with these steps:

```bash
# 1. Test basic CLI interface
Expand Down
25 changes: 2 additions & 23 deletions pkg/workflow/agentic_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ type CodingAgentEngine interface {
// GetInstallationSteps returns the GitHub Actions steps needed to install this engine
GetInstallationSteps(workflowData *WorkflowData) []GitHubActionStep

// GetExecutionConfig returns the configuration for executing this engine
GetExecutionConfig(workflowData *WorkflowData, logFile string) ExecutionConfig
// GetExecutionSteps returns the GitHub Actions steps for executing this engine
GetExecutionSteps(workflowData *WorkflowData, logFile string) []GitHubActionStep

// RenderMCPConfig renders the MCP configuration for this engine to the given YAML builder
RenderMCPConfig(yaml *strings.Builder, tools map[string]any, mcpTools []string)
Expand All @@ -52,27 +52,6 @@ type CodingAgentEngine interface {
GetLogParserScript() string
}

// ExecutionConfig contains the configuration for executing an agentic engine
type ExecutionConfig struct {
// StepName is the name of the GitHub Actions step
StepName string

// Command is the shell command to execute (for CLI-based engines)
Command string

// Action is the GitHub Action to use (for action-based engines)
Action string

// Inputs are the inputs to pass to the action
Inputs map[string]string

// Environment variables needed for execution
Environment map[string]string

// Steps is an optional list of custom steps to inject before command invocation
Steps []map[string]any
}

// BaseEngine provides common functionality for agentic engines
type BaseEngine struct {
id string
Expand Down
Loading
Loading