-
Notifications
You must be signed in to change notification settings - Fork 37
Update awf to v0.6.0, add --proxy-logs-dir flag and remove find step #5346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
📰 BREAKING: Smoke Copilot Playwright is now investigating this pull request. Sources say the story is developing... |
|
🤖 SYSTEM_INIT: Smoke Copilot No Firewall ACTIVATED. PROCESSING pull request. ALL SUBSYSTEMS ONLINE. |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the gh-aw-firewall (awf) from v0.5.1 to v0.6.0, leveraging a new feature that allows direct specification of the proxy logs directory using the --proxy-logs-dir flag. This eliminates the need for post-execution log discovery and simplifies the workflow execution.
- Updated the default firewall version from v0.5.1 to v0.6.0
- Added
--proxy-logs-dir /tmp/gh-aw/sandbox/firewall/logsflag to the awf command - Removed the shell script that searched for and moved log directories after execution
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/constants/constants.go | Updated DefaultFirewallVersion from v0.5.1 to v0.6.0 |
| pkg/constants/constants_test.go | Updated test expectation for DefaultFirewallVersion to v0.6.0 |
| pkg/workflow/copilot_engine.go | Added --proxy-logs-dir flag to awf command and removed post-execution log discovery script |
| .github/workflows/weekly-issue-summary.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/smoke-copilot.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/smoke-copilot-playwright.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/research.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/release.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/python-data-charts.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/mcp-inspector.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/firewall.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/firewall-escape.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/docs-noob-tester.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/daily-repo-chronicle.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/daily-news.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/cli-consistency-checker.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
| .github/workflows/artifacts-summary.lock.yml | Updated awf version in install step and added --proxy-logs-dir flag; removed log moving script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Smoke Test Results (Copilot Engine)Last 2 Merged PRs:
Test Results:
Overall Status: PASS
|
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Status: PASS
|
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Status: PASS
|
Smoke Test Results✅ Playwright MCP: Successfully navigated to https://github.com and verified page title contains "GitHub" Overall Status: PASS
|
|
Convert embedded custom agents to prompt file format
|
Updates gh-aw-firewall to v0.6.0 which introduces
--proxy-logs-dirfor specifying the proxy logs directory directly, eliminating the need for post-execution log discovery.Changes
DefaultFirewallVersionv0.5.1 → v0.6.0--proxy-logs-dir /tmp/gh-aw/sandbox/firewall/logsto awf commandawf-agent-logs-*orcopilot-logs-*directories is no longer neededBefore/After
Before (v0.5.1):
After (v0.6.0):
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Changeset
--proxy-logs-dirflag to direct firewall logs to/tmp/gh-aw/sandbox/firewall/logs, and remove the post-runfindstep that relocated agent logs.Smoke Test Summary