-
Notifications
You must be signed in to change notification settings - Fork 37
fix: Correct actions/setup-node@v6 SHA and make validation fail in strict mode #5565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@mrjf we should prompt the compiler to do these checks as part of the compilation with "--validate" flag |
|
@copilot in this PR, please also prompt the compiler to do these checks as part of the compilation with "--validate" flag so that we catch this earlier |
…flag Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
Implemented in d56d53c. The Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
CI tests were failing due to an incorrect SHA for
actions/setup-node@v6in the action pins configuration and a stale test assertion.Changes
actions/setup-node@v6SHA from2028fbc5c25fe9cf00d9f06a71cc4710d4507903to395ad3262231945c25e8478fd5baf05154b1d79f(verified viagit ls-remote)TestGetActionPinsSortingto expect 23 pins (was 22).lock.ymlfiles with the correct SHA--validateflag: ModifiedValidateActionSHAsInLockFileto return an error when outdated SHAs are found, enabling earlier detection of SHA mismatches during compilation--strict), SHA mismatches now cause compilation to fail (matching behavior of zizmor/poutine/actionlint). Without strict mode, SHA mismatches emit warnings but don't fail compilation for backward compatibility.The Makefile's
recompiletarget already uses--validate, so this change ensures SHA mismatches are detected duringmake recompileandmake agent-finish.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.