Skip to content

Split safe-inputs setup into separate JavaScript/config and tool file steps #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Dec 4, 2025
Merged

Split safe-inputs setup into separate JavaScript/config and tool file steps #5568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f34d67
Initial plan
Copilot Dec 4, 2025
85b2343
Initial plan for splitting safe-inputs setup step
Copilot Dec 4, 2025
2e5c2de
Split safe-inputs setup step into two steps
Copilot Dec 4, 2025
702236c
Merge branch 'main' into copilot/update-compiler-safe-inputs
pelikhan Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/daily-performance-summary.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .github/workflows/daily-team-status.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion .github/workflows/dev.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion .github/workflows/test-python-safe-input.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion pkg/workflow/mcp_servers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@ func (c *Compiler) generateMCPSetup(yaml *strings.Builder, tools map[string]any,

// Write safe-inputs MCP server if configured and feature flag is enabled
if IsSafeInputsEnabled(workflowData.SafeInputs, workflowData) {
yaml.WriteString(" - name: Setup Safe Inputs MCP\n")
// Step 1: Write JavaScript and config files
yaml.WriteString(" - name: Setup Safe Inputs JavaScript and Config\n")
yaml.WriteString(" run: |\n")
yaml.WriteString(" mkdir -p /tmp/gh-aw/safe-inputs/logs\n")

Expand Down Expand Up @@ -343,6 +344,11 @@ func (c *Compiler) generateMCPSetup(yaml *strings.Builder, tools map[string]any,
}
yaml.WriteString(" EOFSI\n")
yaml.WriteString(" chmod +x /tmp/gh-aw/safe-inputs/mcp-server.cjs\n")
yaml.WriteString(" \n")

// Step 2: Generate tool files (js/py/sh)
yaml.WriteString(" - name: Setup Safe Inputs Tool Files\n")
yaml.WriteString(" run: |\n")

// Generate individual tool files (sorted by name for stable code generation)
safeInputToolNames := make([]string, 0, len(workflowData.SafeInputs.Tools))
Expand Down
Loading