Refactor campaign code to pkg/campaign with schema validation and comprehensive tests

[Copilot]

Addresses feedback on #6082 to improve campaign management code structure, reuse existing frontmatter parsing, and add JSON schema validation.

Changes

Package structure

• Moved campaign code from pkg/cli/campaigns.go to pkg/campaign package
• Split 857-line monolith into 5 focused modules:
  • spec.go: Type definitions
  • loader.go: Loading and filtering with parser.ExtractFrontmatterFromContent
  • validation.go: JSON schema validation
  • status.go: Runtime status and metrics
  • command.go: CLI integration

Validation improvements

• Created campaign_spec_schema.json for structured validation
• Implemented schema validation using gojsonschema (matches workflow validation pattern)
• Separate validation spec type excludes runtime fields from schema checks

Before (manual frontmatter parsing):

lines := strings.Split(content, "\n")
if len(lines) == 0 || strings.TrimSpace(lines[0]) != "---" {
    return nil, fmt.Errorf("must start with YAML frontmatter")
}
// ... 30+ lines of parsing logic

After (reuse parser package):

result, err := parser.ExtractFrontmatterFromContent(string(data))
if err != nil {
    return nil, fmt.Errorf("failed to parse frontmatter: %w", err)
}

Test coverage

• 45 tests across 5 test files (loader, validation, filtering, creation, integration)
• All campaign package tests passing

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• go.googlesource.com
  • Triggering command: /update-job-proxy /update-job-proxy /usr/bin/gh /usr/local/sbin//etc/ssl/certs/feffd413.0 basename /usr�� ity_-_G4.pem test /bin/test 52c538d.0 git est basename /usr�� ntrust.net_Premium_2048_Secure_Server_CA.pem test /home/dependabot/bin/test 94d09e5.0 git /bin/test test (dns block)
  • Triggering command: /update-job-proxy /update-job-proxy DROP /usr/bin/readlinextensions.objectformat test -e e=false readlink /usr/bin/test test %H %ct %D 3f456775b00c7065--objects test -e e=false f6ca3761:go.mod /bin/git ommScope_Public_/usr/sbin/ip6tables %H %ct %D 0 /usr/bin/git (dns block)
• go.uber.org
  • Triggering command: /update-job-proxy /update-job-proxy /usr/bin/gh /usr/local/sbin//etc/ssl/certs/feffd413.0 basename /usr�� ity_-_G4.pem test /bin/test 52c538d.0 git est basename /usr�� ntrust.net_Premium_2048_Secure_Server_CA.pem test /home/dependabot/bin/test 94d09e5.0 git /bin/test test (dns block)
  • Triggering command: /update-job-proxy /update-job-proxy DROP /usr/bin/readlinextensions.objectformat test -e e=false readlink /usr/bin/test test %H %ct %D 3f456775b00c7065--objects test -e e=false f6ca3761:go.mod /bin/git ommScope_Public_/usr/sbin/ip6tables %H %ct %D 0 /usr/bin/git (dns block)
• go.yaml.in
  • Triggering command: /update-job-proxy /update-job-proxy /usr/bin/gh /usr/local/sbin//etc/ssl/certs/feffd413.0 basename /usr�� ity_-_G4.pem test /bin/test 52c538d.0 git est basename /usr�� ntrust.net_Premium_2048_Secure_Server_CA.pem test /home/dependabot/bin/test 94d09e5.0 git /bin/test test (dns block)
  • Triggering command: /update-job-proxy /update-job-proxy DROP /usr/bin/readlinextensions.objectformat test -e e=false readlink /usr/bin/test test %H %ct %D 3f456775b00c7065--objects test -e e=false f6ca3761:go.mod /bin/git ommScope_Public_/usr/sbin/ip6tables %H %ct %D 0 /usr/bin/git (dns block)
• gopkg.in
  • Triggering command: /update-job-proxy /update-job-proxy /usr/bin/gh /usr/local/sbin//etc/ssl/certs/feffd413.0 basename /usr�� ity_-_G4.pem test /bin/test 52c538d.0 git est basename /usr�� ntrust.net_Premium_2048_Secure_Server_CA.pem test /home/dependabot/bin/test 94d09e5.0 git /bin/test test (dns block)
  • Triggering command: /update-job-proxy /update-job-proxy DROP /usr/bin/readlinextensions.objectformat test -e e=false readlink /usr/bin/test test %H %ct %D 3f456775b00c7065--objects test -e e=false f6ca3761:go.mod /bin/git ommScope_Public_/usr/sbin/ip6tables %H %ct %D 0 /usr/bin/git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[mnkiefer]

@pelikhan: LGTM! 🎉