-
Notifications
You must be signed in to change notification settings - Fork 39
Fix firewall logs not printing due to incorrect directory path #6153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The firewall logs parsing step was looking in the wrong directory. The awf firewall command writes logs to /tmp/gh-aw/sandbox/firewall/logs/ but the parsing step was looking in /tmp/gh-aw/squid-logs-${sanitizedName}/. Fixed by updating parse_firewall_logs.cjs to use the correct path.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
📰 BREAKING: Smoke Copilot Playwright is now investigating this pull request. Sources say the story is developing... |
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
Smoke Test: Copilot Engine ✅ PASS
Status: PASS
|
Smoke Test Results (Claude)Last 2 merged PRs:
Test Results: Status: PARTIAL PASS (5/6 core tests passed, Playwright network issue)
|
Smoke Test Results - Run 20142056907✅ Playwright MCP: Successfully navigated to https://github.com - Page title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub" Status: FAIL (1/3 tests failed)
|
Copilot Smoke Test ResultsTest Results:
Overall Status: FAIL Note: safeinputs-gh tool experiencing network/TLS issues preventing GitHub API access. 📰🔥📋 https://github.com/githubnext/gh-aw/actions/runs/20142056914 fer issue #6153 🗺️ |
|
Recent merged PRs: feat(cli): add campaign management cmds, specs, and examples; Enable GH_DEBUG for gh CLI commands in shared/gh.md safe-input tool
|
Firewall logs were not appearing in step 31 of workflow runs because the parsing script looked in the wrong directory.
Root Cause
Path mismatch between where logs are written vs. read:
awf:/tmp/gh-aw/sandbox/firewall/logs//tmp/gh-aw/squid-logs-${sanitizedName}/This caused the parsing step to silently fail with "No firewall logs directory found".
Changes
pkg/workflow/js/parse_firewall_logs.cjsto use the correct hardcoded pathWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
go.googlesource.com/update-job-proxy /update-job-proxy -o br-90f520d0cac6 -j DOCKER-ISOLATION-STAGE-2 Trus_Root_CA.pem test /usr/bin/basename 52c538d.0 git 2c2426be9c86c01e--global basename /usr�� CA1.pem test test t_Certificate_Au/usr/sbin/iptables git est test(dns block)/update-job-proxy /update-job-proxy DROP est test -e /etc/ssl/certs/e-n1 hema-go /bin/git 2.pem -e /usr/bin/sed git conf�� --global b496654757886ef41ef5ac72:go.mod /bin/git 29b127/shallow.l/usr/sbin/iptables -e 1 git(dns block)go.uber.org/update-job-proxy /update-job-proxy -o br-90f520d0cac6 -j DOCKER-ISOLATION-STAGE-2 Trus_Root_CA.pem test /usr/bin/basename 52c538d.0 git 2c2426be9c86c01e--global basename /usr�� CA1.pem test test t_Certificate_Au/usr/sbin/iptables git est test(dns block)/update-job-proxy /update-job-proxy DROP est test -e /etc/ssl/certs/e-n1 hema-go /bin/git 2.pem -e /usr/bin/sed git conf�� --global b496654757886ef41ef5ac72:go.mod /bin/git 29b127/shallow.l/usr/sbin/iptables -e 1 git(dns block)go.yaml.in/update-job-proxy /update-job-proxy -o br-90f520d0cac6 -j DOCKER-ISOLATION-STAGE-2 Trus_Root_CA.pem test /usr/bin/basename 52c538d.0 git 2c2426be9c86c01e--global basename /usr�� CA1.pem test test t_Certificate_Au/usr/sbin/iptables git est test(dns block)/update-job-proxy /update-job-proxy DROP est test -e /etc/ssl/certs/e-n1 hema-go /bin/git 2.pem -e /usr/bin/sed git conf�� --global b496654757886ef41ef5ac72:go.mod /bin/git 29b127/shallow.l/usr/sbin/iptables -e 1 git(dns block)gopkg.in/update-job-proxy /update-job-proxy -o br-90f520d0cac6 -j DOCKER-ISOLATION-STAGE-2 Trus_Root_CA.pem test /usr/bin/basename 52c538d.0 git 2c2426be9c86c01e--global basename /usr�� CA1.pem test test t_Certificate_Au/usr/sbin/iptables git est test(dns block)/update-job-proxy /update-job-proxy DROP est test -e /etc/ssl/certs/e-n1 hema-go /bin/git 2.pem -e /usr/bin/sed git conf�� --global b496654757886ef41ef5ac72:go.mod /bin/git 29b127/shallow.l/usr/sbin/iptables -e 1 git(dns block)https://api.github.com/user/usr/bin/gh gh api user --jq .login b-script.git b-script.git /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh api user --jq .login 2256544/b357/_pkg_.a /tmp/go-build2242256544/b142/vet--log-format 2256544/b357=>(http block)/usr/bin/gh gh api user --jq .login -bool -buildtags aae22e73e0881c93b4c32152cfdce94f612/log.json -errorsas -ifaceassert -nilfunc /opt/hostedtoolc--json -uns�� pload-artifact/git/ref/tags/v5 /tmp/go-build2242256544/b061/vet.cfg ache/node/24.11.1/x64/bin/node(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset
/tmp/gh-aw/sandbox/firewall/logs/and removed workflow name sanitization.