-
Notifications
You must be signed in to change notification settings - Fork 36
WIP: test smoke-copilot-safe-inputs #6800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
Smoke Test Results (Run 20323316830) Last 2 merged PRs:
✅ GitHub MCP - Retrieved recent pull requests Overall: PASS
|
|
Smoke test results:
|
Smoke Test Results (Claude - Run 20323316853)Recent PRs:
Test Results: Status: PASS (5/6 tests)
|
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
…licts GitHub Actions treats environment variable names as case-insensitive, so defining both HTTP_PROXY and http_proxy in the same env block causes a 'already defined' error when dispatching workflows via API. This fix modifies injectFirewallProxyEnv to only add uppercase proxy environment variables (HTTP_PROXY, HTTPS_PROXY), removing the lowercase variants (http_proxy, https_proxy) that were causing the conflict. The uppercase variants will be passed through to tools and made available in their process environment with both uppercase and lowercase variants by the operating system. Fixes the workflow dispatch error: (Line: 4284, Col: 11): 'http_proxy' is already defined Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Safe-inputs tools run INSIDE the AWF container and should access allowed domains directly. AWF handles domain filtering automatically. Setting HTTP_PROXY/HTTPS_PROXY forces tools to route through Squid proxy even for allowed domains, causing TLS handshake failures: Post "https://api.github.com/graphql": http: server gave HTTP response to HTTPS client tls: first record does not look like a TLS handshake The gh CLI and other safe-inputs tools should access api.github.com directly through AWF, not through the Squid proxy. This completely removes the firewall proxy environment variable injection that was added in commit c11e769. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
0f0bc16 to
5c0817f
Compare
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
|
Testing is completed |
Signed-off-by: Jiaxiao (mossaka) Zhou duibao55328@gmail.com
Changeset
Changeset