Skip to content

Refactor update_command.go: Split 1,331-line file into 8 focused modules #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 5 commits into from
Dec 19, 2025
Merged

Refactor update_command.go: Split 1,331-line file into 8 focused modules #6897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c9cf47
Initial plan
Copilot Dec 18, 2025
018c37c
Extract types, display, extension check, git, and actions logic
Copilot Dec 18, 2025
cd7349b
Extract merge logic to update_merge.go
Copilot Dec 18, 2025
c438e80
Extract workflow logic and complete refactoring
Copilot Dec 18, 2025
70f34c5
Fix linter warnings: Add nolint directives for unused fallback functions
Copilot Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/cli/download_workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import (
var downloadLog = logger.New("cli:download_workflow")

// resolveLatestReleaseViaGit finds the latest release using git ls-remote
//
//nolint:unused // Fallback implementation for when GitHub API is unavailable
func resolveLatestReleaseViaGit(repo, currentRef string, allowMajor, verbose bool) (string, error) {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatVerboseMessage(fmt.Sprintf("Fetching latest release for %s via git ls-remote (current: %s, allow major: %v)", repo, currentRef, allowMajor)))
Expand Down Expand Up @@ -95,6 +97,8 @@ func resolveLatestReleaseViaGit(repo, currentRef string, allowMajor, verbose boo
}

// isBranchRefViaGit checks if a ref is a branch using git ls-remote
//
//nolint:unused // Fallback implementation for when GitHub API is unavailable
func isBranchRefViaGit(repo, ref string) (bool, error) {
downloadLog.Printf("Attempting git ls-remote to check if ref is branch: %s@%s", repo, ref)

Expand Down Expand Up @@ -125,6 +129,8 @@ func isBranchRefViaGit(repo, ref string) (bool, error) {
}

// isBranchRef checks if a ref is a branch in the repository
//
//nolint:unused // Reserved for future use
func isBranchRef(repo, ref string) (bool, error) {
// Use gh CLI to list branches
cmd := workflow.ExecGH("api", fmt.Sprintf("/repos/%s/branches", repo), "--jq", ".[].name")
Expand Down Expand Up @@ -155,6 +161,8 @@ func isBranchRef(repo, ref string) (bool, error) {
}

// resolveBranchHeadViaGit gets the latest commit SHA for a branch using git ls-remote
//
//nolint:unused // Fallback implementation for when GitHub API is unavailable
func resolveBranchHeadViaGit(repo, branch string, verbose bool) (string, error) {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatVerboseMessage(fmt.Sprintf("Fetching latest commit for branch %s in %s via git ls-remote", branch, repo)))
Expand Down Expand Up @@ -189,6 +197,8 @@ func resolveBranchHeadViaGit(repo, branch string, verbose bool) (string, error)
}

// resolveBranchHead gets the latest commit SHA for a branch
//
//nolint:unused // Reserved for future use
func resolveBranchHead(repo, branch string, verbose bool) (string, error) {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatVerboseMessage(fmt.Sprintf("Fetching latest commit for branch %s in %s", branch, repo)))
Expand Down Expand Up @@ -221,6 +231,8 @@ func resolveBranchHead(repo, branch string, verbose bool) (string, error) {
}

// resolveDefaultBranchHeadViaGit gets the latest commit SHA for the default branch using git ls-remote
//
//nolint:unused // Fallback implementation for when GitHub API is unavailable
func resolveDefaultBranchHeadViaGit(repo string, verbose bool) (string, error) {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatVerboseMessage(fmt.Sprintf("Fetching default branch for %s via git ls-remote", repo)))
Expand Down Expand Up @@ -275,6 +287,8 @@ func resolveDefaultBranchHeadViaGit(repo string, verbose bool) (string, error) {
}

// resolveDefaultBranchHead gets the latest commit SHA for the default branch
//
//nolint:unused // Reserved for future use
func resolveDefaultBranchHead(repo string, verbose bool) (string, error) {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatVerboseMessage(fmt.Sprintf("Fetching default branch for %s", repo)))
Expand Down
Loading
Loading