-
Notifications
You must be signed in to change notification settings - Fork 36
Remove stdio mode from safe-inputs, keep HTTP-only transport #6900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot mark safe-inputs.mode as deprecated |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in 65eafa4. The
The field now shows as deprecated in IDEs and schema validators while still accepting "http" for backward compatibility. |
|
@copilot add codemod to remove field "safe-inputs.mode" |
|
🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS. |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
💀 Blimey! Smoke Copilot Safe Inputs failed and walked the plank! No treasure today, matey! ☠️ |
Smoke Test Results for Run 20355875811Last 2 Merged PRs:
Test Results: Overall Status: PASS cc @pelikhan
|
Smoke Test ResultsLast 2 merged PRs:
Test Results:
Status: PASS
|
|
Recent merged PRs: "Refactor update_command.go: Split 1,331-line file into 8 focused modules"; "[WIP] Disable sandbox agent flag in strict mode"
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in 0477e0f. Added a codemod that removes the deprecated The codemod:
Testing shows it correctly handles simple and complex workflows with multiple tools and comments. |
Safe-inputs previously supported two transport modes: HTTP (server in separate step) and stdio (server started by agent). This removes stdio mode, leaving only HTTP transport.
Changes
Core implementation (
pkg/workflow/safe_inputs.go):SafeInputsModeStdioconstant andIsSafeInputsStdioMode()functionIsSafeInputsHTTPMode()to always return true for non-nil configsgenerateSafeInputsMCPServerScript()andrenderSafeInputsMCPConfigWithOptions()Schema changes (
pkg/parser/schemas/*.json):["http", "stdio"]to["http"]modefield as deprecated with"deprecated": trueand"x-deprecation-message"Test cleanup (
pkg/workflow/safe_inputs_mode_test.go):Workflow generation (
pkg/workflow/mcp_servers.go,pkg/workflow/mcp_renderer.go):Codemod for migration (
pkg/cli/fix_codemods.go,pkg/cli/fix_command.go,pkg/cli/fix_command_test.go):safe-inputs-mode-removalcodemod that automatically removes the deprecatedmodefieldgh aw fix --writeto update workflows automaticallyBreaking Change
Workflows with
safe-inputs.mode: stdiowill now use HTTP mode. The mode field is marked as deprecated and ignored by the compiler. IDEs and schema validators will display deprecation warnings for this field.Migration
Users can automatically remove the deprecated field from their workflows by running:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.