Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 18, 2025

Safe-inputs previously supported two transport modes: HTTP (server in separate step) and stdio (server started by agent). This removes stdio mode, leaving only HTTP transport.

Changes

Core implementation (pkg/workflow/safe_inputs.go):

  • Removed SafeInputsModeStdio constant and IsSafeInputsStdioMode() function
  • Simplified IsSafeInputsHTTPMode() to always return true for non-nil configs
  • Updated config parsing to ignore mode field and always use HTTP
  • Removed stdio branch from generateSafeInputsMCPServerScript() and renderSafeInputsMCPConfigWithOptions()

Schema changes (pkg/parser/schemas/*.json):

  • Changed mode enum from ["http", "stdio"] to ["http"]
  • Marked mode field as deprecated with "deprecated": true and "x-deprecation-message"
  • Updated descriptions to reflect HTTP-only support and deprecation status

Test cleanup (pkg/workflow/safe_inputs_mode_test.go):

  • Removed stdio-specific test cases
  • Retained HTTP mode tests

Workflow generation (pkg/workflow/mcp_servers.go, pkg/workflow/mcp_renderer.go):

  • Removed conditional HTTP mode checks
  • Always generate server config and startup steps

Codemod for migration (pkg/cli/fix_codemods.go, pkg/cli/fix_command.go, pkg/cli/fix_command_test.go):

  • Added safe-inputs-mode-removal codemod that automatically removes the deprecated mode field
  • Preserves formatting, comments, and all other tool configurations
  • Can be run with gh aw fix --write to update workflows automatically
  • Includes comprehensive tests for the codemod functionality

Breaking Change

Workflows with safe-inputs.mode: stdio will now use HTTP mode. The mode field is marked as deprecated and ignored by the compiler. IDEs and schema validators will display deprecation warnings for this field.

Migration

Users can automatically remove the deprecated field from their workflows by running:

gh aw fix --write
Original prompt

Only keep the safe-inputs mode mounted in the agent job over http and remove support for the local, MCP server configure for the agent.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits December 18, 2025 23:53
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove support for local MCP server configuration Remove stdio mode from safe-inputs, keep HTTP-only transport Dec 19, 2025
Copilot AI requested a review from pelikhan December 19, 2025 00:06
@pelikhan
Copy link
Contributor

@copilot mark safe-inputs.mode as deprecated

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 19, 2025

@copilot mark safe-inputs.mode as deprecated

Done in 65eafa4. The safe-inputs.mode field is now marked as deprecated in both schema files with:

  • "deprecated": true
  • "x-deprecation-message" explaining the field is no longer used
  • Updated description indicating it's deprecated

The field now shows as deprecated in IDEs and schema validators while still accepting "http" for backward compatibility.

@pelikhan
Copy link
Contributor

@copilot add codemod to remove field "safe-inputs.mode"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

💀 Blimey! Smoke Copilot Safe Inputs failed and walked the plank! No treasure today, matey! ☠️

@github-actions
Copy link
Contributor

Smoke Test Results for Run 20355875811

Last 2 Merged PRs:

Test Results:
✅ GitHub MCP - Verified default toolsets (get_me not available as expected)
✅ File Writing - Created test file successfully
✅ Bash Tools - Executed commands and verified output
✅ GitHub MCP Default Toolset - Confirmed get_me fails with 403 (expected behavior)
✅ Cache Memory - Created and verified cache file
✅ Available Tools - Listed all safe output tools

Overall Status: PASS

cc @pelikhan

📰 BREAKING: Report filed by Smoke Copilot fer issue #6900 🗺️

@github-actions
Copy link
Contributor

Smoke Test Results

Last 2 merged PRs:

Test Results:

  • ✅ GitHub MCP: Retrieved 2 merged PRs successfully
  • ✅ File Writing: Created /tmp/gh-aw/agent/smoke-test-copilot-20355875813.txt
  • ✅ Bash Tool: File verified with cat
  • ✅ Playwright MCP: Navigated to github.com, title contains "GitHub"
  • ✅ Safe Input gh Tool: Accessed GitHub CLI successfully

Status: PASS

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall fer issue #6900 🗺️

@github-actions
Copy link
Contributor

Recent merged PRs: "Refactor update_command.go: Split 1,331-line file into 8 focused modules"; "[WIP] Disable sandbox agent flag in strict mode"
GitHub MCP: ✅
File write /tmp/gh-aw/agent: ✅
Cat verification: ✅
Playwright title check: ✅
Cache memory write: ✅
Safeinputs-gh (gh issues list): ❌ missing tool
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex fer issue #6900 🗺️

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 19, 2025

@copilot add codemod to remove field "safe-inputs.mode"

Done in 0477e0f. Added a codemod that removes the deprecated safe-inputs.mode field.

The codemod:

  • Detects and removes the mode: field from safe-inputs: blocks
  • Preserves all other configurations, comments, and formatting
  • Can be run with gh aw fix --write to automatically update workflows

Testing shows it correctly handles simple and complex workflows with multiple tools and comments.

@pelikhan pelikhan marked this pull request as ready for review December 19, 2025 00:50
@pelikhan pelikhan merged commit a3d3d9d into main Dec 19, 2025
86 of 87 checks passed
@pelikhan pelikhan deleted the copilot/remove-local-mcp-support branch December 19, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants