-
Notifications
You must be signed in to change notification settings - Fork 36
Scope campaign validation to specific files when compiling by name #9022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
| ) | ||
|
|
||
| // initGitRepo initializes a git repository in the given directory | ||
| func initGitRepoForCampaignTest(t *testing.T, dir string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot delete test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted in f390df5
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot when compiling a campaign by name, only validate that campaign file not all. $ ./gh-aw compile my-workflow.campaign.md |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in 59406f1. Now validates only the specific campaign file being compiled: Before: All 7 campaigns validated After: Only the 1 campaign being compiled is validated |
Fix: Scope Campaign Validation to Specific Files When Compiling
Summary
Fixed an issue where campaign validation was running on all campaigns regardless of which workflows were being compiled. The validation is now properly scoped:
Changes Made
compileSpecificFilesto track which specific campaign files are being compiled (list of paths instead of boolean)runPostProcessingto accept list of campaign filesvalidateCampaignsto filter validation to specific campaign files when providedVerification
✅ Non-campaign workflows skip campaign validation:
✅ Specific campaign files validate only that campaign:
✅ All workflows still validates all campaigns:
$ ./gh-aw compile ⚠ Campaign validation: found 7 problem(s) in campaign specs ⚠ Compiled 127 workflow(s)Files Modified
pkg/cli/compile_orchestration.go- Track campaign files list and pass to post-processingpkg/cli/compile_post_processing.go- Accept campaign files list parameterpkg/cli/compile_campaign.go- Filter validation to specific campaign files when providedOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.