-
Notifications
You must be signed in to change notification settings - Fork 34
Support protocol-specific domain filtering (http/https) #9062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update domain validation to accept http:// and https:// prefixes - Preserve protocol prefixes when processing domains - Add comprehensive tests for protocol-specific filtering - Maintain backward compatibility for domains without protocols Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Add validateNetworkAllowedDomains to validate network.allowed domains - Reject invalid protocols (only http:// and https:// allowed) - Skip ecosystem identifiers in validation - Add integration tests for invalid protocol rejection - All protocol-specific domain tests passing Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
@copilot work on integration tests, smoke tests in github actions and documentation updates related to this change/ |
- Add smoke-protocol-domains.md workflow to test protocol filtering - Update network.md with protocol-specific filtering documentation - Update network-configuration.md guide with protocol examples - Verify protocol prefixes are preserved in compiled workflows - All integration tests passing Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Done! Added in commit 88c3ff2: Integration Tests:
Smoke Test:
Documentation:
|
| @@ -0,0 +1,73 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot instead of adding a new smoke workflow, modify existing ones to add test coverage for protocol domains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit bb38ea9:
- Removed standalone
smoke-protocol-domains.mdworkflow - Integrated protocol testing into
smoke-copilot.md(added HTTPS-only and HTTP-only domain tests) - Integrated protocol testing into
smoke-codex-firewall.md(added HTTPS-only domain test) - Both workflows now verify protocol prefixes are preserved in AWF
--allow-domainsflag - Reduced code duplication while maintaining test coverage
- Remove standalone smoke-protocol-domains workflow - Add protocol-specific domain testing to smoke-copilot workflow - Add protocol-specific domain testing to smoke-codex-firewall workflow - Test HTTPS-only (https://api.github.com) and HTTP-only (http://httpbin.org) filtering - Verify protocol prefixes are preserved in AWF --allow-domains flag - All tests passing Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
|
📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️ |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰 |
Merged 10 commits from main including: - AWF logs summary for CI firewall reports - Agentic instructions for workflow recompilation issues - Simplified spinner with 33% code reduction - CLI error output console formatting - Copilot session log naming support (process-*.log) - Copilot CLI 0.0.375 and Codex 0.79.0 with conversation markdown - Read-only permissions fixes for safe-outputs - Copy project duplicate prevention Resolved 99 merge conflicts in workflow lock files. All 123/125 workflows regenerated. Protocol-specific domain filtering preserved. Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Done in commit 381908e. Merged 10 commits from main (941ce13) including AWF logs summary, agentic recompilation instructions, console formatting improvements, and Copilot CLI 0.0.375/Codex 0.79.0 updates. Resolved 99 merge conflicts in workflow lock files. All 123/125 workflows regenerated successfully. Protocol-specific domain filtering ( |
|
@copilot merge main and regenerate workflows |
Branch is already up to date with main (941ce13) from the previous merge in commit 381908e. Regenerated all 123/125 workflows successfully with no changes needed. Protocol-specific domain filtering ( |
Resolve conflicts in smoke workflow files by keeping protocol-specific domain filtering changes (https://api.github.com, http://httpbin.org). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰 |
|
✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️ |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test Results - Copilot EngineLast 2 Merged PRs:
Test Results:
Overall Status: PASS cc @Mossaka (assignee)
|
Smoke Test Results✅ File Writing: Created test file successfully Overall Status: PASS
|
|
Smoke Test Results (Codex)
|
Smoke Test Results❌ Playwright MCP - Tool not available Overall Status: FAIL (1/3 tests passed)
|
Smoke Test Results - Claude EngineRecent PRs:
Test Results:
Overall Status: PASS (5/6 tests successful)
|
|
PRs: Support process-*.log naming convention for Copilot session logs; Create issues with agentic instructions when workflows need recompilation
|
|
🤖 ALERT: Smoke Copilot No Firewall failed. ANOMALY_DETECTED. REPAIR_REQUIRED. |
Protocol-Specific Domain Filtering Implementation
✅ Complete - All tasks finished
Implementation
Changes Summary
1. Core Implementation
safe_outputs_domains_validation.go- Protocol validation logiccompiler.go- Network domain validation integrationhttp://,https://) preserved through compilation2. Test Coverage
smoke-copilot.mdandsmoke-codex-firewall.mdhttps://api.github.com)http://httpbin.org)--allow-domainsflag3. Documentation
reference/network.md- Added protocol-specific filtering section with examplesguides/network-configuration.md- Added practical protocol filtering guide4. Code Quality
Latest Main Branch Integrations
This merge brings in these significant updates from main:
Usage
Testing
Unit & Integration Tests:
go test -v -run TestProtocolSpecific ./pkg/workflow/Smoke Test Workflows:
smoke-copilot.md- Tests protocol filtering with Copilot + AWFsmoke-codex-firewall.md- Tests protocol filtering with Codex + AWF--allow-domainsflagDocumentation Links
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Changeset
network.allowedentries; validation and compiler integration for(redacted) andhttps://` prefixes, tests, and documentation updates.Changeset
network.allowedentries; validation and compiler integration for(redacted) andhttps://` prefixes, tests, and documentation updates.