Please add { dot: true, matchBase: true } to minimatch options

[phil-lgr]

Steps to reproduce this issue:

Set excluded_globs: "**/node_modules/**,**/dist/**,**/lib/**,**/built/**,**/public/**,**/.cache/**" to exclude nested files in a monorepo

Like this

      - name: Update diagram
        uses: githubocto/repo-visualizer@main
        with:
          commit_message: "chore(core): update diagram"
          output_file: "docs/assets/images/core-repo-diagram.svg"
          excluded_globs: "**/node_modules/*,**/dist/*,**/lib/*,**/built/*,**/public/*,**/.cache/*"
          excluded_paths: "node_modules,dist,lib,built,.cache,public,out,build,.yarn,.vscode,package-lock.json,yarn.lock"

Expected

E.g. files inside /packages/*/.cache are ignored

Actual behavior

files inside /packages/*/.cache are not ignored by minimatch

---

There is a bunch of bugs with the default minimatch options

Minimatch options:

• https://github.com/micromatch/micromatch#options

Related issues:

• "**/" pattern doesn't match "./" path part isaacs/minimatch#30 (comment)
• Leading './' is not included in the glob regex micromatch/micromatch#199

[phil-lgr]

with micromatch.isMatch(args.path, args.pattern, { dot: true, matchBase: true }) I think it would exclude what people expect

OR

remove the './' before matching with minimatch

I thinkg the only workaround right now is to match:

the ./ before like this:

\.\/**/.cache/**/*.json

in config:

excluded_globs: "\./**/node_modules/**/*,\./**/dist/**/*,\./**/lib/**/*,\./**/built/**/*,\./**/public/**/*,\./**/.cache/**/*"

Edit: no need to escape backslash in yaml

[phil-lgr]

Actually this does not work either, I think the best solution is to remove the ./ prefix

    const format = (str: string) => str.replace(/^\.\//, '');
    const result = micromatch.isMatch(args.path, args.pattern, { format });

Or use this:

          excluded_globs: "(./)?**/node_modules/**/*;(./)?**/dist/**/*;(./)?**/lib/**/*;(./)?**/built/**/*;(./)?**/public/**/*;(./)?**/.cache/**/*"

[phil-lgr]

Even with the above glob, I am unable to exclude .cache files and .node_modules in a monorepository :(

[Wattenberger]

thanks for digging into this! I think my update should do the trick - let me know if you have any unsolved cases!