-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: keyboard shortcut to open app (with setting to disable) #1032
Conversation
Hello @setchy, I've just opened this PR but in DRAFT as I'm having an issue I don't know how to solve, so I'd really appreciate some help on this 😁 Right now the feature/setting is working great, the only problem I have is, when you enable the shortcut setting, then close the app, then reopen it, the shortcut doesn't work -> you have to toggle the setting off and on for it to be registered again I'm having trouble to make the React app that contains the state communicate with the Electron backend responsible for registering the shortcut (PS: feel free to push some changes here if needed) |
@adufr - just ran this on my machine to get a feel for how this would work... i know this is still WIP, but sharing that on my device the shortcut briefly shows the window before it hides. i also get some other random artifact on another display at the same time 🤔 |
That's really weird 🤨 I just tried it again and it works perfectly. I even tried it with a 4 monitors setup and no issue whatsoever... You're running MacOS right? Which version are you using? (I'm on 14.4.1) |
Correct, macOS 14.4.1 |
@adufr - is this PR / enhancement still of importance to yourself? |
Considering that a lot of things changed recently, I'll try resolving the conflicts, to see if it works, and if it doesn't I'll just close it... |
thanks mate. let us know if we can assist 🙏 |
continuation: #1260 |
Related issues
#995
Context
Discussion
CmdOrCtrl+Alt+G
)