Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve zoomFactor on restarts #1035

Merged

Conversation

adufr
Copy link
Contributor

@adufr adufr commented Apr 17, 2024

Related issues

#1034

Context

Small tweak to retrieve the previous zoomFactor on app start

@setchy
Copy link
Member

setchy commented Apr 17, 2024

I just tested on v5.3.0 and for me the previous zoom level is preserved, but with a visible flicker on first load.

Is it the flicker that what this is resolving @adufr ?

@adufr
Copy link
Contributor Author

adufr commented Apr 17, 2024

I just tested on v5.3.0 and for me the previous zoom level is preserved, but with a visible flicker on first load.

Is it the flicker that what this is resolving @adufr ?

I've just added a small video in the issue #1034 to better describe it

@setchy
Copy link
Member

setchy commented Apr 17, 2024

I just tested on v5.3.0 and for me the previous zoom level is preserved, but with a visible flicker on first load.
Is it the flicker that what this is resolving @adufr ?

I've just added a small video in the issue #1034 to better describe it

thanks. odd, that works for me 🤷‍♂️

@afonsojramos afonsojramos merged commit e7dc36e into gitify-app:main Apr 17, 2024
7 checks passed
@afonsojramos afonsojramos linked an issue Apr 17, 2024 that may be closed by this pull request
1 task
@setchy setchy added bug Something isn't working enhancement New feature or enhancement to existing functionality and removed bug Something isn't working labels Apr 17, 2024
@setchy setchy added this to the Release 5.4.0 milestone Apr 17, 2024
@adufr adufr deleted the fix/zoom-factor-reset-on-restart branch April 17, 2024 17:31
@adufr adufr mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom factor is lost on restarts
4 participants