Skip to content

fix(discussions): simplify search syntax and avoid over filtering for edge cases #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 14, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented May 10, 2024

Combo PR

🧼 further simplification of discussions code

  • rename and move search syntax function into graphql/utils.ts
  • fetch only the most recent discussion
  • move helper logic into api/client where it better belongs

🔧 fix a handful of edge-cases that occur when an old discussion is moved from done -> inbox as unread:

  • remove updated:>timestamp+padding from search condition (notification timestamp doesn't match the discussion updatedAt under these conditions
  • remove results filtering by viewerSubscription (discussion left as IGNORED when under these conditions)

@setchy setchy added the refactor Refactoring of existing feature label May 10, 2024
@setchy setchy added this to the Release 5.6.0 milestone May 10, 2024
@setchy setchy changed the title refactor(discussions): search syntax fix(discussions): simplify search syntax and avoid over filtering for edge cases May 12, 2024
@setchy setchy added the bug Something isn't working label May 12, 2024
@afonsojramos afonsojramos merged commit e27547c into main May 14, 2024
@afonsojramos afonsojramos deleted the refactor/discussions-search-syntax branch May 14, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants