-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: biome linter updates #1226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems more explicit now, which is good. Just some risk in introducing state issues :)
@afonsojramos - appreciate your feedback on this too when you get a chance 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As most are dependency arrays for callbacks I think it should be fine!
According to React docs:
https://react.dev/reference/react/useCallback Seems to me that passing these functions as dependencies won't have any impact tbh... |
A selection of updates to remove biome warnings, including:
noUnusedFunctionParamaters
nursery rule and fix lint errorsuseDefaultSwitchClause
nursery rule and fix lint errors