fix: prevent default filters from getting overwritten #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear Filters button was not unchecking selected filters because of a reference between settings and defaultSettings. i.e., whenever filters changed, the filter reasons in the defaultFilters object also changed, which is not desirable. Using the spread operator to get selected filters fixes this issue
aravindparappil46
requested review from
afonsojramos,
bmulholland and
setchy
as code owners
setchy
approved these changes
Jan 23, 2025
|
Thanks @aravindparappil46, appreciate the fix 🛠️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Clear Filters" button was not unchecking selected filters because of a reference between
settingsanddefaultSettings. i.e., whenever filters changed, the filter reasons in thedefaultFiltersobject also mutated, which is not desirable.Using the spread operator to get selected filters fixes this issue.
Video of bug:
Screen.Recording.2025-01-22.at.6.40.59.PM.mov