Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): Switch to Tailwind v4 CSS config #1772

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bmulholland
Copy link
Collaborator

This is their new configuration format, but it's a bit tricky. I'm not confident all these changes are working as expected -- especially the scrollbar ones.

@bmulholland bmulholland changed the title chore: Switch to Tailwind v4 CSS config chore(config): Switch to Tailwind v4 CSS config Jan 24, 2025
Base automatically changed from 01-24-chore_deps_update_tailwindcss_to_v4 to 01-24-chore_fix_tailwind_v3_installation January 24, 2025 11:36
Base automatically changed from 01-24-chore_fix_tailwind_v3_installation to main January 24, 2025 11:48
@github-actions github-actions bot added the dependency Dependency updates label Jan 24, 2025
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@github-actions github-actions bot removed the dependency Dependency updates label Jan 24, 2025
Copy link
Member

@setchy setchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmulholland

We spotted a few visual regressions so adding a "Request Changes" review for future us to remember 🎗️

assets/css/main.css Outdated Show resolved Hide resolved
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy added the refactor Refactoring of existing feature label Jan 28, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants