feat: filter by notification type #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <adam.setch@outlook.com>
github-actions
bot
added
the
enhancement
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
|
Merging since this follows the current "pattern". Will work on reducing the duplication shortly |
bmulholland
reviewed
Feb 26, 2025
| @@ -25,10 +25,7 @@ export const FILTERS_STATE_TYPES: Record<FilterStateType, TypeDetails> = { | |||
| title: 'Other', | |||
| description: 'Catch all for any other notification states', | |||
| }, | |||
| } as Partial<Record<FilterStateType, TypeDetails>> as Record< | |||
There was a problem hiding this comment.
It's always satisfying dropping an as
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured while we're updating the
Filtersmodule, why not add the ability to filter by notification type