Skip to content

Commit

Permalink
Adds todo-anchors for simplifying the continuation of the current work
Browse files Browse the repository at this point in the history
  • Loading branch information
sergeibbb committed Oct 21, 2024
1 parent 2c55948 commit d3d4f28
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/plus/launchpad/launchpad.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ const instanceCounter = getScopedCounter();
const defaultCollapsedGroups: LaunchpadGroup[] = ['draft', 'other', 'snoozed'];

export class LaunchpadCommand extends QuickCommand<State> {
// TODO: The debouncer needs to be cancelled when the step is changed when the quickpick is closed
private readonly updateItemsDebouncer = createAsyncDebouncer(500);
private readonly source: Source;
private readonly telemetryContext: LaunchpadTelemetryContext | undefined;
Expand Down Expand Up @@ -588,6 +589,11 @@ export class LaunchpadCommand extends QuickCommand<State> {
return true;
}

// TODO: This needs to be generalized to work outside of GitHub,
// The current idea is that we should iterate the connected integrations and apply their parsing.
// Probably we even want to build a map like this: { integrationId: identity }
// Then when we iterate local items we can check them to corresponding identitie according to the item's repo type.
// Same with API: we iterate connected integrations and search in each of them with the corresponding identity.
const prUrlIdentity = getPullRequestIdentityValuesFromSearch(value);
if (prUrlIdentity.prNumber == null) {
// Not a valid PR URL
Expand Down
4 changes: 4 additions & 0 deletions src/plus/launchpad/launchpadProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,10 @@ export class LaunchpadProvider implements Disposable {
}

private async getSearchedPullRequests(search: string) {
// TODO: This needs to be generalized to work outside of GitHub,
// The current idea is that we should iterate the connected integrations and apply their parsing.
// Probably we even want to build a map like this: { integrationId: identity }
// Then we iterate connected integrations and search in each of them with the corresponding identity.
const { ownerAndRepo, prNumber } = getPullRequestIdentityValuesFromSearch(search);
let result: TimedResult<SearchedPullRequest[] | undefined> | undefined;

Expand Down

0 comments on commit d3d4f28

Please sign in to comment.