Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove '-review' from Gerrit Remote reviewDomain() #1787

Closed
Levistator opened this issue Jan 27, 2022 · 3 comments · Fixed by #1954
Closed

Remove '-review' from Gerrit Remote reviewDomain() #1787

Levistator opened this issue Jan 27, 2022 · 3 comments · Fixed by #1954
Assignees
@eamodio
Labels
feature New feature or request needs-verification Request for verification
Milestone
12.1

Comments

@Levistator
Copy link

Please remove the addition of '-review' to the subdomain portion of the get reviewDomain() function.

It is potentially breaking for Gerrit installations that are at gerrit.example.com instead of gerrit-review.example.com

This should either be a configurable option or not assumed at all.
@Levistator Levistator added feature New feature or request triage Needs to be looked at labels Jan 27, 2022
Levistator pushed a commit to Levistator/vscode-gitlens that referenced this issue Jan 27, 2022
Closes gitkraken#1787 - Remove '-review' from reviewDomain()
5e7d1da 
Was breaking integration with my installation of gerrit.
Why should the subdomain be assumed to be anything other than what was
directly defined in the settings.json
@adambadura
Copy link

I have exactly this issue. Or even worse I think... We have gerrit-wrsl1.int.net.nokia.com host and for the Change-Id: link it is changed to gerrit-wrsl1-review.int.net. Not only -review is added to the first component, which should not (in our setup) but also .nokia.com suffix is somehow dropped.

@adambadura adambadura mentioned this issue Mar 14, 2022
Closed
@felipecrs felipecrs mentioned this issue Apr 7, 2022
Merged
7 tasks
@felipecrs
Copy link
Contributor

#1954 aims to solve this issue.

@eamodio eamodio removed the triage Needs to be looked at label Apr 13, 2022
@eamodio eamodio self-assigned this Apr 13, 2022
@eamodio eamodio added this to the Soon™ milestone Apr 13, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Apr 13, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
@eamodio eamodio modified the milestones: Soon™, June 2022 May 16, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
feature New feature or request needs-verification Request for verification
Projects
None yet
Milestone
12.1
Development

Successfully merging a pull request may close this issue.

Adds support for vanilla Gerrit felipecrs/vscode-gitlens
4 participants
@eamodio @adambadura @Levistator @felipecrs