Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce re-rendering by disabling animation in blame info in the status bar #1829

Closed
gdh1995 opened this issue Feb 23, 2022 · 2 comments
Closed
Assignees
Labels
bug Something isn't working needs-verification Request for verification
Milestone

Comments

@gdh1995
Copy link

gdh1995 commented Feb 23, 2022

Currently behavior

  1. Currently Gitlens shows blame information in the status bar (controlled by gitlens.statusBar.*)
  2. When I move caret to another line, it will update the blame information
  3. When gitlens.statusBar.reduceFlicker is true by default, there's a "turning circle" before blame info before new info gets loaded

What I want

I want (a new setting item) to replace the circle animation with:

  • either a "static icon" which means "updating"
  • or keep the icon unchanged, and switch to another icon on further errors or timeout events

The benefits of this feature

Firstly, this means: further reduce flickers; easier to read; not attract attention in any sense.

Secondly, a static icon will save computer power a lot: during my tests using Developer Tools -> Render -> Paint flashing,

  1. with the turning circle, moveing caret causes to render many UI parts
    1. if a VS Code window is small, then many left icons flash
      with-turning-circle
    1. if a window is large, then there're a strange full-area rendering, like:
      large-window-with-turning-circle
  1. when reduceFlicker=false, there's no turning circle, and then
    without-circle
@gdh1995 gdh1995 added feature New feature or request triage Needs to be looked at labels Feb 23, 2022
@gdh1995 gdh1995 changed the title [feature requst] Less re-rendering by disable animation in blame info in the status bar [feature requst] Less re-rendering by disabling animation in blame info in the status bar Feb 23, 2022
@eamodio eamodio removed the triage Needs to be looked at label Feb 28, 2022
@eamodio eamodio added this to the Soon™ milestone Feb 28, 2022
@eamodio eamodio changed the title [feature requst] Less re-rendering by disabling animation in blame info in the status bar Reduce re-rendering by disabling animation in blame info in the status bar Mar 15, 2022
@eamodio eamodio self-assigned this Mar 15, 2022
@eamodio eamodio added bug Something isn't working and removed feature New feature or request labels Mar 15, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Mar 15, 2022
@eamodio
Copy link
Member

eamodio commented Mar 15, 2022

I've changed this from a spinner to just a watch icon to reduce the visual noise. FYI, in the current insiders version of VS Code the re-rendering issue you are seeing above seems to be resolved whether a spinning icon is used or not.

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Mar 17, 2022
@eamodio eamodio modified the milestones: Soon™, Shipped Mar 17, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for verification
Projects
None yet
Development

No branches or pull requests

2 participants