Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show line blame for uncommitted lines #1987

Closed
ghost opened this issue May 4, 2022 · 9 comments
Closed

Don't show line blame for uncommitted lines #1987

ghost opened this issue May 4, 2022 · 9 comments
Assignees
Labels
feature New feature or request verified ✔ Verified
Milestone

Comments

@ghost
Copy link

ghost commented May 4, 2022

Line blames are quite useful for committed lines, but for uncommitted lines it doesn't really show you any information you don't already know. But more importantly if you use other extensions that show line annotations, for example compiler errors, then those can be pushed out of the window by the blame, making them unreadable. So it would be very useful if you could disable line blames for uncommitted lines, especially since these are the lines that are most likely to contain errors that would need to be annotated.

Is that possible? There doesn't seem to be an option for it, but I'm not even sure if VS Code's API would support this.

@ghost ghost added feature New feature or request triage Needs to be looked at labels May 4, 2022
@eamodio eamodio removed the triage Needs to be looked at label May 4, 2022
@eamodio eamodio added this to the Soonish™ milestone May 4, 2022
@eamodio eamodio added the under-discussion Being considered or is under active discussion label May 4, 2022
@HebaruSan
Copy link

Hi, I just came here to request this. "You, 1 second ago"? Yes, I know that. And now I'm thinking about that text instead of the changes I'm making.

@dieegorenan
Copy link

Hi, I get the point when you are doing a small feature and commit often. But sometimes when you start a big refactoring, moving some code around, doing some copy and paste, you might get lost and this information can be helpful.

@eamodio
Copy link
Member

eamodio commented Aug 3, 2022

@janlarres-msft @HebaruSan would you want the annotation removed completely or would you like it shorter/less distracting -- maybe something like (e.g. replacing the text with a ✏️)

image

@dieegorenan If implemented, this would be an opt-out setting, so this wouldn't impact anyone who gets value out of it today.

@ghost
Copy link
Author

ghost commented Aug 4, 2022

I think either would be fine for me - a single emoji doesn't take up much space, so it wouldn't make much of a difference for the main issue of obscuring other annotations.

@eamodio
Copy link
Member

eamodio commented Aug 4, 2022

@janlarres-msft Do you have a screenshot/example of another anotation being pushed out of view? I want to make sure I have a test case to make sure it works correctly.

@eamodio
Copy link
Member

eamodio commented Aug 4, 2022

Thinking about it more, a better alternative, imo, is to have a new setting similar to gitlens.currentLine.format but for uncommitted lines (e.g. gitlens.currentLine.formatUncommitted), which would allow you to replace the format string for uncommitted lines. Then you can customize it how you see fit, or leave it blank to nuke the annotation all together.

@eamodio eamodio self-assigned this Aug 4, 2022
@eamodio eamodio removed the under-discussion Being considered or is under active discussion label Aug 4, 2022
@eamodio eamodio modified the milestones: Soon™, 12.2 Aug 4, 2022
@eamodio eamodio closed this as completed in 0300619 Aug 4, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Aug 4, 2022
@eamodio
Copy link
Member

eamodio commented Aug 4, 2022

Added a new gitlens.currentLine.uncommittedChangesFormat -- setting it to null (the default) follows the gitlens.currentLine.format settings, while setting it to an empty string will disable the annotations on uncommitted changes.

Here's where you can customize the setting:

image

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@ghost
Copy link
Author

ghost commented Aug 12, 2022

It's working fine for me, thanks!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Aug 12, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

3 participants