Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t prompt for auth on activation on web #2159

Closed
TylerLeonhardt opened this issue Aug 23, 2022 · 2 comments
Closed

Don’t prompt for auth on activation on web #2159

TylerLeonhardt opened this issue Aug 23, 2022 · 2 comments

Comments

@TylerLeonhardt
Copy link

GitLens Version

12.1.2

VS Code Version

1.70.0-insiders

Git Version

N/A in the web

Description

GitLens currently asks for auth on activation in the web. This leads to users being annoyed:
microsoft/vscode#158911
If they don’t want to login just yet.

My recommendation is for them to not prompt every time GitLens activates (which is every time) and instead only prompt when acted upon by the user:

  • when the user clicks on a button in a welcome view
  • in-line editor decoration
  • on command

Logs, Screenshots, Screen Captures, etc

Screen.Recording.2022-08-23.at.16.11.25.mov
@TylerLeonhardt TylerLeonhardt added potential-bug triage Needs to be looked at labels Aug 23, 2022
@eamodio
Copy link
Member

eamodio commented Aug 28, 2022

Closing as duplicate of #2166 (since I forgot about this issue)

@eamodio eamodio closed this as completed Aug 28, 2022
@eamodio eamodio added duplicate and removed potential-bug triage Needs to be looked at labels Aug 28, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants