Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't always prompt for GitHub authentication on virtual repositories #2166

Closed
eamodio opened this issue Aug 28, 2022 · 2 comments
Closed

Don't always prompt for GitHub authentication on virtual repositories #2166

eamodio opened this issue Aug 28, 2022 · 2 comments
Assignees
@eamodio
Labels
bug Something isn't working needs-verification Request for verification
Milestone
12.2

Comments

@eamodio
Copy link
Member

eamodio commented Aug 28, 2022

Refs: microsoft/vscode#158911
@eamodio eamodio self-assigned this Aug 28, 2022
@eamodio eamodio added the bug Something isn't working label Aug 28, 2022
@eamodio eamodio added this to the 12.2 milestone Aug 28, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Aug 28, 2022
@eamodio
Copy link
Member Author

eamodio commented Aug 28, 2022

We are now only asking once with a prompt (as on a virtual repository GitLens can't provide any functionality without authentication), and if you decline, then you will get notification saying that "GitLens has been disabled. Authentication is required for GitLens to work with remote GitHub repositories." with the option to re-enable (which will re-prompt for auth).

If you ignore/close that notification, you won't get prompted again -- only the badge will show on the Accounts icon.

This was referenced Aug 28, 2022
Open
Closed
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working needs-verification Request for verification
Projects
None yet
Milestone
12.2
Development

No branches or pull requests
1 participant
@eamodio