Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresponsive "commits" view and "branches" view update due to git log #2482

Closed
wro-ableton opened this issue Feb 2, 2023 · 6 comments
Closed
Assignees
Labels
bug Something isn't working needs-verification Request for verification
Milestone

Comments

@wro-ableton
Copy link

Description

In some cases, the commits and branches view becomes really unresponsive and takes a long time to update. It seems that on one branch, it takes up to a minute to perform the following call on a forced commits view refresh:

git log --format=<format> -M -m --name-status --full-history -n41 <my_branch> -- (Will take 58106ms)

I've tried to reproduce this by copying the command and it seems to only take long when I increase the diff.renameLimit. By default with my config, this call instead gave me a warning: inexact rename detection was skipped due to too many files. warning.

The repository is not open source.

GitLens Version

13.2.0

VS Code Version

Version: 1.74.3 (user setup)
Commit: 97dec172d3256f8ca4bfb2143f3f76b503ca0534
Date: 2023-01-09T16:59:02.252Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19043
Sandboxed: No

Git Version

git version 2.28.0.windows.1

Logs, Screenshots, Screen Captures, etc

No response

@wro-ableton wro-ableton added potential-bug triage Needs to be looked at labels Feb 2, 2023
@eamodio
Copy link
Member

eamodio commented Feb 2, 2023

@wro-ableton When you run git log --format=<format> -M -m --name-status --full-history -n41 <my_branch> -- from the terminal you see it take ~58s or only from GitLens? If you run the same command without the -m and/or the -M (my guess it would be the -M causing the slowdown) does it still take as long?

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Feb 2, 2023
@wro-ableton
Copy link
Author

wro-ableton commented Feb 3, 2023

Hey, thanks for the quick reply!
When I set the diff.renameLimit to a large enough number for git not to complain about the rename detection, removing the -m option will speed up the call to bascially an instant response. However, removing -M doesn't seem to speed up the call at all.

And yes, when I run the command in my terminal, it also takes that lone when I have the diff.renameLimit high. Is GitLense using it's own git configuration?

@eamodio
Copy link
Member

eamodio commented Feb 3, 2023

Wow the -m huh. Wouldn't have guessed, do you have many large merge commits?

Yeah GitLens sets diff.renameLimit=0

@wro-ableton
Copy link
Author

Not really. I think the merge commits should be the the ball park for what's to be expected from a commercial repositories with ~100 collaborators.

@github-actions github-actions bot added the inactive Issue has not had recent required feedback label Feb 14, 2023
@gitkraken gitkraken deleted a comment from github-actions bot Feb 14, 2023
@eamodio eamodio added triage Needs to be looked at bug Something isn't working and removed needs-more-info Needs further information, steps, details, etc. inactive Issue has not had recent required feedback potential-bug triage Needs to be looked at labels Feb 14, 2023
@eamodio eamodio added this to the Soon™ milestone Feb 14, 2023
@eamodio eamodio modified the milestones: Soon™, 13.6 Apr 10, 2023
@eamodio eamodio modified the milestones: 13.6, 13.7 May 8, 2023
@eamodio eamodio modified the milestones: 14.0, 14.1 Jun 5, 2023
@eamodio eamodio modified the milestones: 14.1, 14.2 Jul 13, 2023
@eamodio eamodio modified the milestones: 14.2, 14.3 Aug 8, 2023
@eamodio eamodio modified the milestones: 14.3, 14.4 Sep 8, 2023
@eamodio eamodio removed this from the 14.4 milestone Oct 18, 2023
@eamodio eamodio added this to the 14.5 milestone Oct 18, 2023
@axosoft-ramint axosoft-ramint modified the milestones: 14.5, 14.6 Nov 14, 2023
@eamodio eamodio self-assigned this Nov 27, 2023
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Nov 27, 2023
@eamodio
Copy link
Member

eamodio commented Nov 27, 2023

Sorry for the long delay on this one. If you can, could you please verify this fix in tomorrow's (v2023.11.27xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

eamodio added a commit that referenced this issue Dec 5, 2023
Adds Open Details to top level
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Dec 18, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for verification
Projects
None yet
Development

No branches or pull requests

3 participants