-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git path with spaces is not properly quoted in the command #2680
Comments
I'm observing a similar issue with v13.6.0. I am on Windows 10 using GitBash. My path doesn't have spaces, but the '/' character is not being properly quoted, so I get the following error in the terminal:
Downgrading to 13.5, the command works:
|
Can you please see if this issue is still reproducible in the pre-release edition of GitLens? I added some fallbacks that should help and more logging if not.Thanks! You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view. If that still doesn't resolve the issue, please enable debug logging by running the GitLens: Enable Debug Logging command from the Command Palette (F1 or ctrl/cmd+shift+p). This will enable logging to the GitLens & GitLens (Git) channels in the Output pane. Once enabled, please reproduce the issue, and attach the logs from the GitLens and GitLens (Git) channels. Thank you! |
It's still reproducing for me on the Pre-Release version as well. I've attached the logs from both channels. |
Pre-release do not solve the issue, the logs are as follows:
And
|
The delete branch selection seems to be missing from context menu in the prerelease version. |
@heshammourad @FluffyGhoster @mike-kirkland what shell are you using? If it's not powershell, I just checked in a fix for a missing quote path in 0fa0355. Will be in pre-release tomorrow. |
I am using a bash terminal window in VSC on windows. Doing gitlens commands via the context menu gets the slashes in the path to git backwards. C:\Users\xxx@xxx\AppData\Local\Programs\Git\cmd\git.exe -C "c:/Projects/xxx/xxx" -c "core.editor=code --wait --reuse-window" branch xx main The error message has all the slashes removed. bash: C:Usersxxx@xxxAppDataLocalProgramsGitcmdgit.exe: command not found Entering the command manually with the slashes reversed works. |
@eamodio I'm using Git Bash on Windows, so I can test this fix when it's available. |
@heshammourad and others, I published a new pre-release with another fix (and more logging) -- please let me know if this resolves the issue |
@eamodio I switched to v2023.5.1616 on the pre-release track, but trying to delete a branch still fails in the same way:
|
@heshammourad Ugh, sorry 😢. Can you please grab logs for that? |
Nm, I see the issue there. |
@heshammourad OK, sorry about that. I just kicked off a new pre-release build that should resolve the issue you are having. I thought it was the same issue as others with a space in the path of |
@eamodio My issue is resolved, but I don't have spaces in my path to test the other scenario. Thanks for the fix! |
I am getting a different error, with the latest prerelease:
|
@FluffyGhoster Can you provide logs please? Also what |
How do you print/obtain this info? |
From the command palette run |
No Terminal result were found in the user settings.json |
With the latest prerelease, the problem is not reproducible anymore, it seems |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
(I have translated the error message from the localized version)
GitLens Version
13.6
VS Code Version
Version: 1.78.2 (system setup)
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T14:39:26.248Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: Yes
Git Version
git version 2.40.0.windows.1
Logs, Screenshots, Screen Captures, etc
The text was updated successfully, but these errors were encountered: