Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'undo commit' command from gitlens inspect #2746

Closed
d13 opened this issue Jun 16, 2023 Discussed in #2745 · 9 comments
Closed

Remove 'undo commit' command from gitlens inspect #2746

d13 opened this issue Jun 16, 2023 Discussed in #2745 · 9 comments
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@d13
Copy link
Member

d13 commented Jun 16, 2023

Discussed in #2745

Originally posted by mdj-uk June 16, 2023
When in the gitlens inspect file history, or commit history, there is a button to undo the latest commit (the first icon from the left):
image

I find it very easy to hit that accidentally, which makes me scared to use just about any gitlens feature.

Is there any way to remove it, or to require a confirmation step? I couldn't find any option in the extension settings.

@d13 d13 added the feature New feature or request label Jun 16, 2023
@d13 d13 added this to the Soon™ milestone Jun 16, 2023
@yurymann
Copy link

yurymann commented Dec 2, 2023

Is it possible to bump the priority of this, please?
As a new GitLens user, I discovered this "feature" accidentally yesterday and was upleasantly surprised. Have to pay explicit attention now to not hitting it every time I navigate in that panel.

Any action affecting working copy should ask for a confirmation.

@eamodio eamodio self-assigned this Dec 5, 2023
@eamodio eamodio modified the milestones: Soon™, 14.6 Dec 5, 2023
@eamodio eamodio added bug Something isn't working and removed feature New feature or request labels Dec 5, 2023
@eamodio
Copy link
Member

eamodio commented Dec 5, 2023

Fixed by 056e19c (wrong commit message)

Moved Undo Commit to Commit submenu

@eamodio eamodio closed this as completed Dec 5, 2023
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Dec 5, 2023
@eamodio
Copy link
Member

eamodio commented Dec 5, 2023

Can you please verify this fix in tomorrow's (v2023.12.05xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@yurymann
Copy link

yurymann commented Dec 6, 2023

@eamodio I've just tried v2023.12.504 and didn't notice any change: the same Undo Commit button is avilable and when pressed, updates the working copy. What was supposed to change?

Sorry, can't attach the screenshot as I was testing it on the work machine.

@eamodio
Copy link
Member

eamodio commented Dec 6, 2023

@yurymann Are you looking at this in the File History or Line History views?

@yurymann
Copy link

yurymann commented Dec 6, 2023

In Commits on the Source Control panel. Please see the picture.
Sorry if it was not clear before - I assumed that it uses the same widget in all the views.

image

@mdj-uk
Copy link

mdj-uk commented Dec 7, 2023

For me it's removed from the file history:
image

but still present in the commit history:
image
That's after selecting the pre-release version of the extension v2023.12.704.

Is the plan to remove it from the commit widget as well?

@eamodio
Copy link
Member

eamodio commented Dec 7, 2023

No, this is only for the File History & Line History. You can open another issue for the Commits view, but given the usage and intent in that view I'm not convinced on removing that option, but if there is enough community agreement we can revisit.

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Dec 7, 2023
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Dec 18, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

4 participants